-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select into null exception #1621
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1621 +/- ##
============================================
- Coverage 67.47% 67.46% -0.01%
Complexity 323 323
============================================
Files 600 600
Lines 114806 114806
Branches 999 999
============================================
- Hits 77462 77454 -8
- Misses 37137 37145 +8
Partials 207 207
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If select closure in select into result is empty, we just skip saving, and the job is succeed. But users can't find the output file. It's not intuitive.
We should throw an exception.
close #1459
What is the current behavior? (You can also link to an open issue here)
throw new Exception("select empty, skip save")
What is the new behavior (if this is a feature change)?