Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select into null exception #1621

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

KaidoWang
Copy link
Contributor

@KaidoWang KaidoWang commented Apr 13, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    If select closure in select into result is empty, we just skip saving, and the job is succeed. But users can't find the output file. It's not intuitive.
    We should throw an exception.

close #1459

  • What is the current behavior? (You can also link to an open issue here)
    throw new Exception("select empty, skip save")

  • What is the new behavior (if this is a feature change)?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2022

SDK Test Report

  72 files    72 suites   4m 56s ⏱️
172 tests 169 ✔️ 3 💤 0
212 runs  209 ✔️ 3 💤 0

Results for commit cb8065f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2022

Linux Test Report

       56 files       183 suites   42m 3s ⏱️
  8 210 tests   8 210 ✔️ 0 💤 0
12 126 runs  12 126 ✔️ 0 💤 0

Results for commit cb8065f.

♻️ This comment has been updated with latest results.

@lumianph lumianph linked an issue Apr 13, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1621 (10417ac) into main (fad76a8) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 10417ac differs from pull request most recent head cb8065f. Consider uploading reports for the commit cb8065f to get more accurate results

@@             Coverage Diff              @@
##               main    #1621      +/-   ##
============================================
- Coverage     67.47%   67.46%   -0.01%     
  Complexity      323      323              
============================================
  Files           600      600              
  Lines        114806   114806              
  Branches        999      999              
============================================
- Hits          77462    77454       -8     
- Misses        37137    37145       +8     
  Partials        207      207              
Impacted Files Coverage Δ
...paradigm/openmldb/batch/nodes/SelectIntoPlan.scala 60.00% <0.00%> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
src/sdk/db_sdk.cc 63.06% <0.00%> (-1.21%) ⬇️
src/nameserver/name_server_impl.cc 38.87% <0.00%> (-0.09%) ⬇️
src/tablet/tablet_impl.cc 43.48% <0.00%> (+0.05%) ⬆️
hybridse/src/vm/transform.cc 84.58% <0.00%> (+0.15%) ⬆️
hybridse/src/node/plan_node.cc 84.94% <0.00%> (+0.17%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db9c24...cb8065f. Read the comment docs.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit cfd64b4 into 4paradigm:main Apr 15, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch: return error if select into gets empty
5 participants