-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: full iterator #1616
feat: full iterator #1616
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1616 +/- ##
============================================
+ Coverage 73.46% 73.55% +0.08%
- Complexity 325 347 +22
============================================
Files 611 613 +2
Lines 119415 119851 +436
Branches 997 1010 +13
============================================
+ Hits 87733 88157 +424
- Misses 31475 31485 +10
- Partials 207 209 +2
Continue to review full report at Codecov.
|
it need to modify |
can add sql test in I tried with following case in std::string ddl = "create table " + name +
"("
"col1 int not null,"
"col2 bigint default 112 not null,"
"col4 string default 'test4' not null,"
"col5 date default '2000-01-01' not null,"
"col6 timestamp default 10000 not null,"
"index(key=col1, ts=col2)) options(partitionnum=8);";
ok = router->ExecuteDDL(db, ddl, &status);
ASSERT_TRUE(ok);
ASSERT_TRUE(router->RefreshCatalog());
std::string sql;
int expect = 1000;
for (int i = 0; i < expect; i++) {
sql = "insert into " + name + " values(" + std::to_string(i) + ", 1, '1', '2021-01-01', 1);";
ASSERT_TRUE(router->ExecuteInsert(db, sql, &status));
}
auto res = router->ExecuteSQL(db, "select * from " + name, &status);
ASSERT_TRUE(res);
int count = 0;
while (res->Next()) {
count++;
}
LOG(WARNING) << "count = " << count;
EXPECT_EQ(count, expect); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.