Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: full iterator #1616

Merged
merged 34 commits into from
Apr 29, 2022
Merged

feat: full iterator #1616

merged 34 commits into from
Apr 29, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Apr 12, 2022

No description provided.

@dl239 dl239 linked an issue Apr 12, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2022

SDK Test Report

  73 files    73 suites   6m 59s ⏱️
174 tests 171 ✔️ 3 💤 0
215 runs  212 ✔️ 3 💤 0

Results for commit 048f35a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2022

Linux Test Report

       57 files       186 suites   1h 5m 17s ⏱️
  8 397 tests   8 389 ✔️ 8 💤 0
12 313 runs  12 305 ✔️ 8 💤 0

Results for commit 048f35a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1616 (048f35a) into main (1cc07b8) will increase coverage by 0.08%.
The diff coverage is 82.04%.

@@             Coverage Diff              @@
##               main    #1616      +/-   ##
============================================
+ Coverage     73.46%   73.55%   +0.08%     
- Complexity      325      347      +22     
============================================
  Files           611      613       +2     
  Lines        119415   119851     +436     
  Branches        997     1010      +13     
============================================
+ Hits          87733    88157     +424     
- Misses        31475    31485      +10     
- Partials        207      209       +2     
Impacted Files Coverage Δ
hybridse/include/vm/engine.h 96.05% <ø> (ø)
hybridse/src/codec/type_codec.cc 75.00% <ø> (ø)
...n/java/com/_4paradigm/hybridse/sdk/JitManager.java 0.00% <0.00%> (ø)
...m/_4paradigm/openmldb/batch/nodes/FilterPlan.scala 0.00% <0.00%> (ø)
...com/_4paradigm/openmldb/batch/nodes/JoinPlan.scala 49.62% <0.00%> (-1.54%) ⬇️
...om/_4paradigm/openmldb/jdbc/PreparedStatement.java 21.45% <ø> (ø)
.../main/java/com/_4paradigm/openmldb/sdk/Schema.java 66.66% <ø> (-4.77%) ⬇️
...openmldb/sdk/impl/InsertPreparedStatementImpl.java 41.11% <0.00%> (-1.79%) ⬇️
src/catalog/tablet_catalog.h 50.54% <ø> (+0.54%) ⬆️
src/sdk/result_set_sql.cc 52.38% <0.00%> (ø)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b8f2e...048f35a. Read the comment docs.

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Apr 21, 2022
@dl239 dl239 marked this pull request as ready for review April 21, 2022 12:47
src/flags.cc Outdated Show resolved Hide resolved
src/catalog/distribute_iterator.cc Outdated Show resolved Hide resolved
src/catalog/distribute_iterator.h Show resolved Hide resolved
src/catalog/tablet_catalog.cc Show resolved Hide resolved
@dl239
Copy link
Collaborator Author

dl239 commented Apr 22, 2022

it need to modify DistributeWindowIterator to reslove select * from t1 where xxx=xxx;

@zhanghaohit
Copy link
Collaborator

can add sql test in sql_cluster_test using DistributedIterator and FullTableIterator?

I tried with following case in sql_cluster_test, but it always failed (get less than 1000):

    std::string ddl = "create table " + name +
                      "("
                      "col1 int not null,"
                      "col2 bigint default 112 not null,"
                      "col4 string default 'test4' not null,"
                      "col5 date default '2000-01-01' not null,"
                      "col6 timestamp default 10000 not null,"
                      "index(key=col1, ts=col2)) options(partitionnum=8);";
    ok = router->ExecuteDDL(db, ddl, &status);
    ASSERT_TRUE(ok);
    ASSERT_TRUE(router->RefreshCatalog());
    std::string sql;
    int expect = 1000;
    for (int i = 0; i < expect; i++) {
        sql = "insert into " + name + " values(" + std::to_string(i) + ", 1, '1', '2021-01-01', 1);";
        ASSERT_TRUE(router->ExecuteInsert(db, sql, &status));
    }
    auto res = router->ExecuteSQL(db, "select * from " + name, &status);
    ASSERT_TRUE(res);
    int count = 0;
    while (res->Next()) {
        count++;
    }
    LOG(WARNING) << "count = " << count;
    EXPECT_EQ(count, expect);

@zhanghaohit zhanghaohit self-requested a review April 27, 2022 09:01
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the sdk openmldb java/python sdk label Apr 28, 2022
@dl239 dl239 merged commit efdb71e into 4paradigm:main Apr 29, 2022
@dl239 dl239 deleted the feat/full_iterator branch April 29, 2022 02:58
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DistributedIterator
3 participants