Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rows cnt in cmd #1601

Merged
merged 2 commits into from
Apr 11, 2022
Merged

fix: add rows cnt in cmd #1601

merged 2 commits into from
Apr 11, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Apr 8, 2022

127.0.0.1:6527/dl> select * from t2;
 ---- --------------- ----------
  c1   c2              c3
 ---- --------------- ----------
  aa   1649228629000   1.300000
 ---- --------------- ----------

1 rows in set

@dl239 dl239 linked an issue Apr 8, 2022 that may be closed by this pull request
@dl239 dl239 requested review from tobegit3hub and aceforeverd April 8, 2022 09:48
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Linux Test Report

       55 files       182 suites   41m 49s ⏱️
  8 200 tests   8 200 ✔️ 0 💤 0
12 116 runs  12 116 ✔️ 0 💤 0

Results for commit d95a8c5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

SDK Test Report

  72 files    72 suites   6m 22s ⏱️
172 tests 169 ✔️ 3 💤 0
212 runs  209 ✔️ 3 💤 0

Results for commit d95a8c5.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

HybridSE Linux Test Report

       65 files       232 suites   7m 4s ⏱️
18 873 tests 18 873 ✔️ 0 💤 0

Results for commit d95a8c5.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

HybridSE Mac Test Report

       65 files       232 suites   6m 25s ⏱️
18 873 tests 18 873 ✔️ 0 💤 0

Results for commit d95a8c5.

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1601 (d95a8c5) into main (1e06650) will increase coverage by 0.00%.
The diff coverage is 60.00%.

@@            Coverage Diff            @@
##               main    #1601   +/-   ##
=========================================
  Coverage     67.21%   67.21%           
  Complexity      323      323           
=========================================
  Files           600      600           
  Lines        114047   114048    +1     
  Branches        995      995           
=========================================
+ Hits          76657    76659    +2     
+ Misses        37183    37182    -1     
  Partials        207      207           
Impacted Files Coverage Δ
...atistics/query_response_time/query_response_time.h 82.60% <0.00%> (ø)
...se/src/passes/physical/group_and_sort_optimized.cc 73.89% <100.00%> (ø)
src/cmd/sql_cmd.h 19.67% <100.00%> (+0.66%) ⬆️
src/nameserver/name_server_impl.cc 38.84% <100.00%> (-0.03%) ⬇️
src/rpc/rpc_client.h 64.86% <0.00%> (-1.36%) ⬇️
src/sdk/db_sdk.cc 64.26% <0.00%> (-0.61%) ⬇️
src/zk/zk_client.cc 83.81% <0.00%> (-0.27%) ⬇️
src/tablet/tablet_impl.cc 42.71% <0.00%> (+0.02%) ⬆️
src/replica/log_replicator.cc 79.47% <0.00%> (+0.65%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e06650...d95a8c5. Read the comment docs.

@dl239 dl239 requested a review from vagetablechicken April 11, 2022 03:12
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit 345617e into 4paradigm:main Apr 11, 2022
@dl239 dl239 deleted the fix/add_row_cnt branch April 11, 2022 03:19
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when select table, row set disappear
4 participants