Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support pre-aggregate in standalone #1573

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

nautaa
Copy link
Collaborator

@nautaa nautaa commented Apr 2, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    fix Create PreAggrTables in standalone mode #1560

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

SDK Test Report

  72 files    72 suites   5m 30s ⏱️
172 tests 169 ✔️ 3 💤 0
212 runs  209 ✔️ 3 💤 0

Results for commit 6274380.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Linux Test Report

       54 files       181 suites   44m 18s ⏱️
  8 193 tests   8 193 ✔️ 0 💤 0
12 109 runs  12 109 ✔️ 0 💤 0

Results for commit 6274380.

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #1573 (6274380) into main (d530c7e) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1573      +/-   ##
============================================
+ Coverage     66.99%   67.15%   +0.15%     
  Complexity      323      323              
============================================
  Files           597      597              
  Lines        113110   113134      +24     
  Branches        994      994              
============================================
+ Hits          75776    75972     +196     
+ Misses        37127    36955     -172     
  Partials        207      207              
Impacted Files Coverage Δ
src/catalog/base.cc 100.00% <ø> (ø)
src/sdk/sql_cluster_router.cc 51.85% <100.00%> (+5.07%) ⬆️
hybridse/src/vm/sql_compiler.cc 80.34% <0.00%> (-0.88%) ⬇️
hybridse/src/plan/planner.cc 93.08% <0.00%> (-0.31%) ⬇️
src/catalog/client_manager.cc 27.53% <0.00%> (-0.29%) ⬇️
src/zk/zk_client.cc 83.81% <0.00%> (-0.27%) ⬇️
src/cmd/sql_cmd_test.cc 100.00% <0.00%> (ø)
src/nameserver/name_server_impl.cc 38.84% <0.00%> (+0.01%) ⬆️
src/tablet/tablet_impl.cc 42.15% <0.00%> (+0.08%) ⬆️
src/sdk/db_sdk.cc 63.06% <0.00%> (+0.60%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d530c7e...6274380. Read the comment docs.

Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhanghaohit
Copy link
Collaborator

@zhanghaohit zhanghaohit merged commit f5fc988 into 4paradigm:main Apr 6, 2022
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PreAggrTables in standalone mode
3 participants