Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support JDBC connection and fix insert prepared statement #1511

Merged
merged 9 commits into from
Mar 31, 2022

Conversation

vagetablechicken
Copy link
Collaborator

closes #81 , closes #1496

We can use jdbc:openmldb:///<db>?zk=<zk_cluster>&zkPath=<zk_path> to connect openmldb. The url schema is the same with python sqlalchemy.

@vagetablechicken vagetablechicken changed the title feat: JDBC support and fix insert prepared statement feat: support JDBC connection and fix insert prepared statement Mar 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

SDK Test Report

  72 files    72 suites   5m 40s ⏱️
172 tests 169 ✔️ 3 💤 0
212 runs  209 ✔️ 3 💤 0

Results for commit 65d716f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022

Linux Test Report

       52 files       179 suites   40m 35s ⏱️
  8 173 tests   8 173 ✔️ 0 💤 0
12 089 runs  12 089 ✔️ 0 💤 0

Results for commit 65d716f.

♻️ This comment has been updated with latest results.

@vagetablechicken
Copy link
Collaborator Author

Apache Pulsar connector

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1511 (65d716f) into main (af937e5) will decrease coverage by 0.06%.
The diff coverage is 57.80%.

@@             Coverage Diff              @@
##               main    #1511      +/-   ##
============================================
- Coverage     66.50%   66.43%   -0.07%     
- Complexity      281      323      +42     
============================================
  Files           583      589       +6     
  Lines        110471   111460     +989     
  Branches        980      994      +14     
============================================
+ Hits          73465    74047     +582     
- Misses        36814    37206     +392     
- Partials        192      207      +15     
Impacted Files Coverage Δ
...ybridse/examples/toydb/src/tablet/tablet_catalog.h 63.15% <0.00%> (-3.51%) ⬇️
hybridse/include/sdk/base.h 19.23% <ø> (ø)
hybridse/include/vm/simple_catalog.h 80.00% <ø> (ø)
hybridse/src/vm/sql_compiler.h 61.53% <ø> (ø)
hybridse/src/vm/transform.h 92.00% <ø> (ø)
...adigm/openmldb/jdbc/CallablePreparedStatement.java 0.00% <ø> (ø)
...om/_4paradigm/openmldb/jdbc/SQLInsertMetaData.java 37.50% <ø> (ø)
...adigm/openmldb/sdk/impl/PreparedStatementImpl.java 70.00% <ø> (ø)
src/sdk/sql_insert_row.h 30.00% <0.00%> (ø)
.../com/_4paradigm/openmldb/jdbc/SimpleResultSet.java 4.08% <4.08%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e974846...65d716f. Read the comment docs.

@vagetablechicken vagetablechicken merged commit 64da36c into 4paradigm:main Mar 31, 2022
dl239 pushed a commit to dl239/OpenMLDB that referenced this pull request Mar 31, 2022
…adigm#1511)

We can use jdbc:openmldb:///<db>?zk=<zk_cluster>&zkPath=<zk_path> to connect openmldb. The url schema is the same with python sqlalchemy.
@lumianph lumianph mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdbc: inserted rows are still in cache after execute [JDBC] Use url to init connection
3 participants