-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support JDBC connection and fix insert prepared statement #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagetablechicken
changed the title
feat: JDBC support and fix insert prepared statement
feat: support JDBC connection and fix insert prepared statement
Mar 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #1511 +/- ##
============================================
- Coverage 66.50% 66.43% -0.07%
- Complexity 281 323 +42
============================================
Files 583 589 +6
Lines 110471 111460 +989
Branches 980 994 +14
============================================
+ Hits 73465 74047 +582
- Misses 36814 37206 +392
- Partials 192 207 +15
Continue to review full report at Codecov.
|
dl239
reviewed
Mar 29, 2022
...penmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/InsertPreparedStatementImpl.java
Show resolved
Hide resolved
dl239
reviewed
Mar 29, 2022
dl239
reviewed
Mar 29, 2022
...penmldb-jdbc/src/main/java/com/_4paradigm/openmldb/sdk/impl/InsertPreparedStatementImpl.java
Show resolved
Hide resolved
vagetablechicken
force-pushed
the
issue-81
branch
from
March 30, 2022 08:04
49a2188
to
5c5c108
Compare
dl239
approved these changes
Mar 31, 2022
aceforeverd
approved these changes
Mar 31, 2022
dl239
pushed a commit
to dl239/OpenMLDB
that referenced
this pull request
Mar 31, 2022
…adigm#1511) We can use jdbc:openmldb:///<db>?zk=<zk_cluster>&zkPath=<zk_path> to connect openmldb. The url schema is the same with python sqlalchemy.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #81 , closes #1496
We can use
jdbc:openmldb:///<db>?zk=<zk_cluster>&zkPath=<zk_path>
to connect openmldb. The url schema is the same with python sqlalchemy.