Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create INFORMATION_SCHEMA.DEPLOY_RESPONSE_TIME on start #1497

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Mar 22, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  1. feat: deploy query statistics #1234
  2. give a bit refactor on 'CreateSystemTable', u only need a enum for input
  3. close Hidden database should create in standalone mode as well #1458
  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

- give a bit refactor on 'CreateSystemTable', u only need a enum for
  input
@aceforeverd aceforeverd added this to the v0.5 milestone Mar 22, 2022
@aceforeverd aceforeverd added the enhancement New feature or request label Mar 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

Linux Test Report

       52 files       179 suites   41m 1s ⏱️
  8 173 tests   8 173 ✔️ 0 💤 0
12 089 runs  12 089 ✔️ 0 💤 0

Results for commit 5ea4431.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

SDK Test Report

  70 files    70 suites   4m 50s ⏱️
157 tests 154 ✔️ 3 💤 0
196 runs  193 ✔️ 3 💤 0

Results for commit 5ea4431.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1497 (5ea4431) into main (90147ca) will decrease coverage by 0.00%.
The diff coverage is 92.59%.

@@             Coverage Diff              @@
##               main    #1497      +/-   ##
============================================
- Coverage     66.54%   66.54%   -0.01%     
  Complexity      281      281              
============================================
  Files           579      580       +1     
  Lines        110290   110300      +10     
  Branches        941      947       +6     
============================================
+ Hits          73395    73399       +4     
- Misses        36703    36709       +6     
  Partials        192      192              
Impacted Files Coverage Δ
src/nameserver/name_server_impl.h 100.00% <ø> (ø)
src/nameserver/name_server_impl.cc 37.74% <81.48%> (+0.09%) ⬆️
src/nameserver/system_table.cc 88.88% <88.88%> (ø)
src/nameserver/system_table.h 96.70% <95.83%> (-0.60%) ⬇️
src/cmd/sql_cmd_test.cc 100.00% <100.00%> (ø)
src/nameserver/system_table_test.cc 100.00% <100.00%> (ø)
src/sdk/sql_cluster_router.cc 44.10% <100.00%> (ø)
src/test/util.h 88.32% <100.00%> (+2.73%) ⬆️
src/base/status.h 60.00% <0.00%> (-40.00%) ⬇️
...adigm/openmldb/batch/spark/OpenmldbJoinedRow.scala 15.25% <0.00%> (-0.82%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90147ca...5ea4431. Read the comment docs.

@zhanghaohit zhanghaohit self-requested a review March 24, 2022 02:56
@aceforeverd aceforeverd merged commit a2cca35 into 4paradigm:main Mar 24, 2022
@aceforeverd aceforeverd deleted the feat/deploy-statistics branch March 24, 2022 06:31
@aceforeverd
Copy link
Collaborator Author

Online Monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden database should create in standalone mode as well
3 participants