Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix simple expression infer #1443

Merged

Conversation

jingchen2222
Copy link
Collaborator

@jingchen2222 jingchen2222 commented Mar 14, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

No

  • Other information:

1. ALL_STAR expression is a kind of simple expression
@jingchen2222 jingchen2222 added the bug Something isn't working label Mar 14, 2022
@jingchen2222 jingchen2222 added this to the v0.5 milestone Mar 14, 2022
@jingchen2222 jingchen2222 self-assigned this Mar 14, 2022
@github-actions
Copy link
Contributor

Linux Test Report

     112 files       238 suites   43m 32s ⏱️
  8 627 tests   8 624 ✔️ 3 💤 0
12 759 runs  12 756 ✔️ 3 💤 0

Results for commit 94b9154.

@github-actions
Copy link
Contributor

HybridSE Linux Test Report

       65 files       231 suites   5m 58s ⏱️
19 160 tests 19 160 ✔️ 0 💤 0

Results for commit 94b9154.

@github-actions
Copy link
Contributor

HybridSE Mac Test Report

       65 files       231 suites   6m 39s ⏱️
19 160 tests 19 160 ✔️ 0 💤 0

Results for commit 94b9154.

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1443 (94b9154) into main (fe2ee26) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1443      +/-   ##
============================================
+ Coverage     65.76%   65.77%   +0.01%     
  Complexity      236      236              
============================================
  Files           571      571              
  Lines        107349   107351       +2     
  Branches        863      863              
============================================
+ Hits          70600    70613      +13     
+ Misses        36597    36586      -11     
  Partials        152      152              
Impacted Files Coverage Δ
hybridse/src/node/sql_node.cc 78.71% <100.00%> (+0.02%) ⬆️
src/sdk/sql_cluster_router.cc 42.24% <0.00%> (-0.34%) ⬇️
hybridse/src/plan/planner.cc 92.84% <0.00%> (-0.32%) ⬇️
src/zk/zk_client.cc 83.28% <0.00%> (ø)
src/nameserver/name_server_impl.cc 37.74% <0.00%> (+0.04%) ⬆️
src/tablet/tablet_impl.cc 38.33% <0.00%> (+0.33%) ⬆️
src/replica/log_replicator.cc 77.85% <0.00%> (+0.65%) ⬆️
src/catalog/tablet_catalog.cc 71.25% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2ee26...94b9154. Read the comment docs.

@aceforeverd aceforeverd merged commit dc636ae into 4paradigm:main Mar 15, 2022
@dl239 dl239 mentioned this pull request Mar 29, 2022
dl239 pushed a commit to dl239/OpenMLDB that referenced this pull request Mar 30, 2022
1. ALL_STAR expression is a kind of simple expression
@lumianph lumianph mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: AllStar expression fails to be an simple expression The following cases will fail in request mode
3 participants