-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix simple expression infer #1443
Merged
aceforeverd
merged 1 commit into
4paradigm:main
from
jingchen2222:fix/last_join_multidatabase_bug
Mar 15, 2022
Merged
fix: fix simple expression infer #1443
aceforeverd
merged 1 commit into
4paradigm:main
from
jingchen2222:fix/last_join_multidatabase_bug
Mar 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. ALL_STAR expression is a kind of simple expression
jingchen2222
requested review from
vagetablechicken,
zhanghaohit and
tobegit3hub
March 14, 2022 18:36
Codecov Report
@@ Coverage Diff @@
## main #1443 +/- ##
============================================
+ Coverage 65.76% 65.77% +0.01%
Complexity 236 236
============================================
Files 571 571
Lines 107349 107351 +2
Branches 863 863
============================================
+ Hits 70600 70613 +13
+ Misses 36597 36586 -11
Partials 152 152
Continue to review full report at Codecov.
|
zhanghaohit
approved these changes
Mar 15, 2022
aceforeverd
approved these changes
Mar 15, 2022
dl239
pushed a commit
to dl239/OpenMLDB
that referenced
this pull request
Mar 30, 2022
1. ALL_STAR expression is a kind of simple expression
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
What is the current behavior? (You can also link to an open issue here)
Resolve Bug: AllStar expression fails to be an simple expression #1444
Resolve The following cases will fail in request mode #749
What is the new behavior (if this is a feature change)?
No
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No