-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor row format with slice formant and single/multi slice row format #1381
Merged
aceforeverd
merged 36 commits into
4paradigm:main
from
tobegit3hub:feat/refactor_row_format_and_support_single_slice_row_format
Mar 15, 2022
Merged
feat: refactor row format with slice formant and single/multi slice row format #1381
aceforeverd
merged 36 commits into
4paradigm:main
from
tobegit3hub:feat/refactor_row_format_and_support_single_slice_row_format
Mar 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tobegit3hub
commented
Mar 5, 2022
- Refactor slice row format
- Support single slice row format
jingchen2222
reviewed
Mar 5, 2022
jingchen2222
reviewed
Mar 5, 2022
jingchen2222
reviewed
Mar 5, 2022
dl239
reviewed
Mar 7, 2022
dl239
reviewed
Mar 7, 2022
dl239
reviewed
Mar 7, 2022
…or_row_format_and_support_single_slice_row_format
…or_row_format_and_support_single_slice_row_format
…or_row_format_and_support_single_slice_row_format
tobegit3hub
commented
Mar 11, 2022
tobegit3hub
commented
Mar 11, 2022
…or_row_format_and_support_single_slice_row_format
Codecov Report
@@ Coverage Diff @@
## main #1381 +/- ##
============================================
+ Coverage 65.76% 65.84% +0.07%
Complexity 236 236
============================================
Files 571 571
Lines 107349 107575 +226
Branches 863 904 +41
============================================
+ Hits 70601 70835 +234
+ Misses 36596 36588 -8
Partials 152 152
Continue to review full report at Codecov.
|
…or_row_format_and_support_single_slice_row_format
dl239
approved these changes
Mar 14, 2022
…or_row_format_and_support_single_slice_row_format
aceforeverd
reviewed
Mar 15, 2022
aceforeverd
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.