fix: fixed always yield true if statement #1379

wuteek · 2022-03-04T08:16:20Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)

This statement always returns true
fixes taskmanager: compare int with null #1377

github-actions · 2022-03-04T09:16:56Z

Linux Test Report

    112 files     238 suites 43m 40s ⏱️
  8 620 tests   8 617 ✔️ 3 💤 0 ❌
12 752 runs 12 749 ✔️ 3 💤 0 ❌

Results for commit 2fbb591.

♻️ This comment has been updated with latest results.

wuteek · 2022-03-04T19:30:18Z

I was wondering if I was able to get some help passing the coverage check? I am new to contributing

lumianph · 2022-03-05T01:50:30Z

I was wondering if I was able to get some help passing the coverage check? I am new to contributing

No worry about that. It failed due to issues of some of our test cases (not related to your code).

vagetablechicken · 2022-03-05T02:25:20Z

...b-taskmanager/src/main/scala/com/_4paradigm/openmldb/taskmanager/spark/SparkJobManager.scala

@@ -78,7 +78,7 @@ object SparkJobManager {
      launcher.setConf("spark.eventLog.dir", TaskManagerConfig.SPARK_EVENTLOG_DIR)
    }

-    if (TaskManagerConfig.SPARK_YARN_MAXAPPATTEMPTS != null) {
+    if ((TaskManagerConfig.SPARK_YARN_MAXAPPATTEMPTS : java.lang.Integer) != null) {


SPARK_YARN_MAXAPPATTEMPTS is int, not Integer, no need to check if null

vagetablechicken

You could do this:

if SPARK_YARN_MAXAPPATTEMPTS >= 1:
    setConf

wuteek · 2022-03-05T05:51:41Z

You could do this:

if SPARK_YARN_MAXAPPATTEMPTS >= 1:
    setConf

Hello, I pushed with the recommendations that you gave. Please let me know if any further issues occur. Thank you!

true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement1377: fixed always yield if true statement

lumianph

LGTM

1377: Fixed always true if statement

922c4a9

aceforeverd requested a review from tobegit3hub March 4, 2022 08:17

dl239 linked an issue Mar 4, 2022 that may be closed by this pull request

taskmanager: compare int with null #1377

Closed

dl239 requested a review from vagetablechicken March 4, 2022 10:25

vagetablechicken reviewed Mar 5, 2022

View reviewed changes

vagetablechicken requested changes Mar 5, 2022

View reviewed changes

1377: fixed always yield true if statement

9916a89

wuteek requested a review from vagetablechicken March 5, 2022 10:11

lumianph approved these changes Mar 5, 2022

View reviewed changes

vagetablechicken approved these changes Mar 6, 2022

View reviewed changes

vagetablechicken merged commit 2f85d12 into 4paradigm:main Mar 6, 2022

dl239 pushed a commit to dl239/OpenMLDB that referenced this pull request Mar 11, 2022

fix: fixed always yield true if statement (4paradigm#1379)

f055b03

lumianph mentioned this pull request Mar 28, 2022

OpenMLDB v0.4 Roadmap #1520

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fixed always yield true if statement #1379

fix: fixed always yield true if statement #1379

wuteek commented Mar 4, 2022

github-actions bot commented Mar 4, 2022 •

edited

Loading

wuteek commented Mar 4, 2022

lumianph commented Mar 5, 2022

vagetablechicken Mar 5, 2022

vagetablechicken left a comment

wuteek commented Mar 5, 2022

lumianph left a comment

fix: fixed always yield true if statement #1379

fix: fixed always yield true if statement #1379

Conversation

wuteek commented Mar 4, 2022

github-actions bot commented Mar 4, 2022 • edited Loading

Linux Test Report

wuteek commented Mar 4, 2022

lumianph commented Mar 5, 2022

vagetablechicken Mar 5, 2022

Choose a reason for hiding this comment

vagetablechicken left a comment

Choose a reason for hiding this comment

wuteek commented Mar 5, 2022

lumianph left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 4, 2022 •

edited

Loading