Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update default execute mode #1332

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Feb 25, 2022

Update the default value of execute mode from online to offline.
The main branch will be modified in #1231

@dl239 dl239 linked an issue Feb 25, 2022 that may be closed by this pull request
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2022

Linux Test Report

     102 files       228 suites   40m 50s ⏱️
  8 593 tests   8 590 ✔️ 3 💤 0
12 715 runs  12 712 ✔️ 3 💤 0

Results for commit cfcb21c.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1332 (cfcb21c) into branch-0.4 (d4a07c5) will decrease coverage by 0.06%.
The diff coverage is 68.08%.

Impacted file tree graph

@@               Coverage Diff                @@
##             branch-0.4    #1332      +/-   ##
================================================
- Coverage         65.50%   65.44%   -0.07%     
  Complexity          222      222              
================================================
  Files               570      570              
  Lines            106347   106375      +28     
  Branches            841      853      +12     
================================================
- Hits              69664    69618      -46     
- Misses            36537    36611      +74     
  Partials            146      146              
Impacted Files Coverage Δ
...openmldb/taskmanager/config/TaskManagerConfig.java 0.00% <0.00%> (ø)
...m/_4paradigm/openmldb/taskmanager/dao/JobInfo.java 0.00% <0.00%> (ø)
...nmldb/taskmanager/server/impl/TaskManagerImpl.java 0.00% <0.00%> (ø)
...paradigm/openmldb/taskmanager/JobInfoManager.scala 0.00% <0.00%> (ø)
src/cmd/sql_cmd.h 21.41% <ø> (-0.10%) ⬇️
..._4paradigm/openmldb/batch/utils/HybridseUtil.scala 60.90% <38.46%> (-2.44%) ⬇️
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 73.89% <66.66%> (-0.24%) ⬇️
...4paradigm/openmldb/batch/api/OpenmldbSession.scala 57.57% <94.11%> (+4.70%) ⬆️
..._4paradigm/openmldb/batch/utils/SparkRowUtil.scala 61.90% <100.00%> (+9.27%) ⬆️
src/storage/table.h 76.08% <0.00%> (-10.87%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f45b30...cfcb21c. Read the comment docs.

@dl239 dl239 merged commit 1977e88 into 4paradigm:branch-0.4 Feb 28, 2022
@dl239 dl239 deleted the feat/default_mode branch February 28, 2022 03:31
@lumianph lumianph mentioned this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set the default value of execute_mode to offline
3 participants