Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add standalone options for sql cluster router #1302

Merged
merged 1 commit into from
Feb 24, 2022
Merged

feat: add standalone options for sql cluster router #1302

merged 1 commit into from
Feb 24, 2022

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added the enhancement New feature or request label Feb 24, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Feb 24, 2022
@tobegit3hub tobegit3hub self-assigned this Feb 24, 2022
@github-actions
Copy link
Contributor

Linux Test Report

     102 files       228 suites   41m 59s ⏱️
  8 610 tests   8 607 ✔️ 3 💤 0
12 737 runs  12 734 ✔️ 3 💤 0

Results for commit 3bb4925.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #1302 (3bb4925) into main (836b341) will increase coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1302      +/-   ##
============================================
+ Coverage     65.52%   65.54%   +0.01%     
  Complexity      222      222              
============================================
  Files           570      570              
  Lines        106352   106449      +97     
  Branches        855      855              
============================================
+ Hits          69683    69767      +84     
- Misses        36523    36536      +13     
  Partials        146      146              
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.h 66.66% <ø> (ø)
src/sdk/sql_router.cc 3.12% <0.00%> (-0.16%) ⬇️
src/sdk/sql_router.h 33.33% <ø> (ø)
src/sdk/sql_cluster_router.cc 32.90% <52.63%> (-0.15%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/rpc/rpc_client.h 64.86% <0.00%> (-1.36%) ⬇️
src/tablet/tablet_impl.cc 37.73% <0.00%> (-0.20%) ⬇️
src/cmd/sql_cmd_test.cc 100.00% <0.00%> (ø)
hybridse/src/node/node_manager.cc 88.66% <0.00%> (ø)
src/nameserver/system_table_test.cc 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 836b341...3bb4925. Read the comment docs.

Copy link
Collaborator

@HuilinWu2 HuilinWu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit aaf9803 into 4paradigm:main Feb 24, 2022
@tobegit3hub tobegit3hub deleted the feat/add_standlone_option_in_cluster_router branch February 24, 2022 10:03
@dl239 dl239 mentioned this pull request Mar 29, 2022
@lumianph lumianph mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support standalone options in sql cluster router for Java/Python SDK
3 participants