Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check null from column and and unit tests for null data #1274

Merged
merged 1 commit into from
Feb 22, 2022
Merged

fix: check null from column and and unit tests for null data #1274

merged 1 commit into from
Feb 22, 2022

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added the bug Something isn't working label Feb 21, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Feb 21, 2022
@tobegit3hub tobegit3hub self-assigned this Feb 21, 2022
@github-actions
Copy link
Contributor

Linux Test Report

     102 files       228 suites   42m 19s ⏱️
  8 593 tests   8 590 ✔️ 3 💤 0
12 715 runs  12 712 ✔️ 3 💤 0

Results for commit 31abd77.

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1274 (31abd77) into main (37e4a6f) will decrease coverage by 0.18%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1274      +/-   ##
============================================
- Coverage     65.68%   65.50%   -0.19%     
+ Complexity      253      222      -31     
============================================
  Files           569      570       +1     
  Lines        106292   106351      +59     
  Branches        815      851      +36     
============================================
- Hits          69823    69666     -157     
- Misses        36306    36539     +233     
+ Partials        163      146      -17     
Impacted Files Coverage Δ
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 73.89% <66.66%> (-0.24%) ⬇️
..._4paradigm/openmldb/batch/utils/SparkRowUtil.scala 61.90% <100.00%> (+9.27%) ⬆️
...m/_4paradigm/openmldb/taskmanager/zk/HostPort.java 0.00% <0.00%> (-55.56%) ⬇️
...openmldb/taskmanager/config/TaskManagerConfig.java 0.00% <0.00%> (-54.17%) ⬇️
...openmldb/taskmanager/server/TaskManagerServer.java 0.00% <0.00%> (-50.00%) ⬇️
...adigm/openmldb/taskmanager/util/BatchJobUtil.scala 0.00% <0.00%> (-41.18%) ⬇️
...adigm/openmldb/taskmanager/zk/FailoverWatcher.java 0.00% <0.00%> (-28.79%) ⬇️
...aradigm/openmldb/taskmanager/zk/ZooKeeperUtil.java 0.00% <0.00%> (-16.18%) ⬇️
...openmldb/taskmanager/client/TaskManagerClient.java 0.00% <0.00%> (-15.60%) ⬇️
...paradigm/openmldb/taskmanager/JobInfoManager.scala 0.00% <0.00%> (-12.85%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e4a6f...31abd77. Read the comment docs.

@vagetablechicken vagetablechicken enabled auto-merge (squash) February 21, 2022 11:47
@vagetablechicken vagetablechicken merged commit 4068123 into 4paradigm:main Feb 22, 2022
@lumianph lumianph mentioned this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenMLDB Batch fail when timestamp value is null
3 participants