Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment about the time units of zk #2021

Closed
vagetablechicken opened this issue Jun 22, 2022 · 1 comment · Fixed by #2285
Closed

comment about the time units of zk #2021

vagetablechicken opened this issue Jun 22, 2022 · 1 comment · Fixed by #2285
Assignees
@liuceyi
Labels
enhancement New feature or request good first issue Good for newcomers storage-engine openmldb storage engine. nameserver & tablet

Comments

@vagetablechicken
Copy link
Collaborator

e.g.

OpenMLDB/src/flags.cc

Line 21 in 79b3450

DEFINE_int32(zk_session_timeout, 2000, "config the zk session timeout of cli, apiserver, tablet or nameserver");

OpenMLDB/src/flags.cc

Line 28 in 79b3450

DEFINE_int32(zk_keep_alive_check_interval, 15000, "config the interval of keep alive check");

We should add the time unit, all milliseconds.
And add it in user doc too.
@aceforeverd aceforeverd added enhancement New feature or request storage-engine openmldb storage engine. nameserver & tablet labels Jun 23, 2022
@vagetablechicken vagetablechicken added the good first issue Good for newcomers label Jul 5, 2022
@liuceyi
Copy link
Contributor

liuceyi commented Jul 27, 2022

Hi, may I work on this issue?

@liuceyi liuceyi mentioned this issue Aug 1, 2022
Merged
liuceyi added a commit to liuceyi/OpenMLDB that referenced this issue Aug 1, 2022
@liuceyi
docs: add time units to comments & docs of zk (4paradigm#2021)
b6c5d1d 
1. Add time units to comment
2. Add time units to user doc
3. Correct the typo
liuceyi added a commit to liuceyi/OpenMLDB that referenced this issue Aug 1, 2022
@liuceyi
docs: add time units to comments & docs of zk (4paradigm#2021)
6746f53 
1. Add time units to comment
2. Add time units to user doc
3. Correct the typo
@vagetablechicken vagetablechicken linked a pull request Aug 3, 2022 that will close this issue
docs: add time units to comments & docs of zk (#2021) #2285
Merged
aceforeverd pushed a commit that referenced this issue Aug 16, 2022
@liuceyi @vagetablechicken
docs: add time units to comments & docs of zk (#2021) (#2285)
801d700 
* docs: add time units to comments & docs of zk (#2021)

1. Add time units to comment
2. Add time units to user doc
3. Correct the typo

* fix line length

Co-authored-by: huangwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liuceyi liuceyi

Labels
enhancement New feature or request good first issue Good for newcomers storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add time units to comments & docs of zk (#2021) liuceyi/OpenMLDB
3 participants
@aceforeverd @vagetablechicken @liuceyi