Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"SQL上线规范和要求 | Online Serving下LAST JOIN的使用规范" example is not correct #1948

Closed
zhanghaohit opened this issue Jun 10, 2022 · 3 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation high-priority
Milestone

Comments

@zhanghaohit
Copy link
Collaborator

Bug Description
Now the doc looks like this:

Online Serving下LAST JOIN的使用规范

  • Join type仅支持LAST JOIN类型
  • 至少有一个JOIN条件是形如left_table.column=right_table.column的EQUAL条件,并且rgith_table.column列需要命中右表的索引
  • 带排序LAST JOIN的情况下,ORDER BY只能支持列表达式,并且列需要命中右表索引的时间列

Example: 支持上线的简单SELECT查询语句范例

CREATE DATABASE db1;

USE db1;
CREATE TABLE t1 (col0 STRING, col1 int, std_time TIMESTAMP, INDEX(KEY=col1, TS=std_time, TTL_TYPE=absolute, TTL=30d));
-- SUCCEED: Create successfully

desc t1;
 --- ---------- ----------- ------ --------- 
  #   Field      Type        Null   Default  
 --- ---------- ----------- ------ --------- 
  1   col0       Varchar     YES             
  2   col1       Int         YES             
  3   std_time   Timestamp   YES             
 --- ---------- ----------- ------ --------- 
 --- -------------------- ------ ---------- ---------- --------------- 
  #   name                 keys   ts         ttl        ttl_type       
 --- -------------------- ------ ---------- ---------- --------------- 
  1   INDEX_0_1639524729   col1   std_time   43200min   kAbsoluteTime  
 --- -------------------- ------ ---------- ---------- --------------- 

Expected Behavior
The example should be for the LAST JOIN example. Not the create table example.

@zhanghaohit zhanghaohit added the bug Something isn't working label Jun 10, 2022
@aceforeverd aceforeverd added the documentation Improvements or additions to documentation label Jun 10, 2022
@aceforeverd
Copy link
Collaborator

aceforeverd commented Jun 10, 2022

@lumianph lumianph assigned aceforeverd and unassigned dl239 Jun 13, 2022
@aceforeverd
Copy link
Collaborator

aceforeverd added a commit to aceforeverd/fedb that referenced this issue Jul 19, 2022
@lumianph lumianph added this to the v0.6 milestone Jul 27, 2022
@aceforeverd
Copy link
Collaborator

fix by #2195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation high-priority
Projects
None yet
Development

No branches or pull requests

4 participants