Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete java dir from gitignore #1531

Closed
dl239 opened this issue Mar 29, 2022 · 7 comments · Fixed by #1743
Closed

Delete java dir from gitignore #1531

dl239 opened this issue Mar 29, 2022 · 7 comments · Fixed by #1743
Assignees
@zjx1319
Labels
good first issue Good for newcomers

Comments

@dl239
Copy link
Collaborator

dl239 commented Mar 29, 2022 •
edited
Loading

hybridse/java dir has been deleted, so we should delete java dir from gitignore
@dl239 dl239 added the good first issue Good for newcomers label Mar 29, 2022
@dl239 dl239 changed the title Delete java dir in gitignore Delete java dir from gitignore Mar 29, 2022
@dl239 dl239 mentioned this issue Mar 29, 2022
Closed
@samyberkane04
Copy link

@dl239
can i work on this issue please ?

@dl239
Copy link
Collaborator Author

dl239 commented Mar 29, 2022

@dl239 can i work on this issue please ?

of course, thank you

@lumianph
Copy link
Collaborator

@dl239 can i work on this issue please ?

thank you for the contribution!

@dl239
Copy link
Collaborator Author

dl239 commented Apr 7, 2022

hi @samyberkane04 are you working for this issue?

@lumianph
Copy link
Collaborator

@samyberkane04 any progress on this issue?

@zjx1319
Copy link
Contributor

zjx1319 commented May 2, 2022

Is anyone working on this issue? If not, I want to have a try

@aceforeverd
Copy link
Collaborator

Is anyone working on this issue? If not, I want to have a try

sure, feel free to send the PR

@zjx1319 zjx1319 mentioned this issue May 2, 2022
Merged
@dl239 dl239 linked a pull request May 5, 2022 that will close this issue
chore: delete java dir from gitignore #1743
Merged
@lumianph lumianph mentioned this issue May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zjx1319 zjx1319

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: delete java dir from gitignore zjx1319/OpenMLDB
5 participants
@lumianph @dl239 @aceforeverd @zjx1319 @samyberkane04