Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception if fetchone fail in Python SDK #1159

Closed
tobegit3hub opened this issue Jan 29, 2022 · 0 comments · Fixed by #1215
Closed

Throw exception if fetchone fail in Python SDK #1159

tobegit3hub opened this issue Jan 29, 2022 · 0 comments · Fixed by #1215
Assignees
@tobegit3hub @HuilinWu2
Labels
bug Something isn't working
Milestone
v0.5

Comments

@tobegit3hub
Copy link
Collaborator

Now if fetchone() in openmldb.dbapi fail, it return the string which is useless and we should throw exception for this error case.

    def fetchone(self):
        if self._resultSet is None: return "call fetchone"
@tobegit3hub tobegit3hub added the bug Something isn't working label Jan 29, 2022
@tobegit3hub tobegit3hub added this to the v0.5 milestone Jan 29, 2022
@HuilinWu2 HuilinWu2 linked a pull request Feb 14, 2022 that will close this issue
feat: support function fetchmany() and fetchall() in python SDK and UT #1215
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobegit3hub tobegit3hub

@HuilinWu2 HuilinWu2

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.5
Development

Successfully merging a pull request may close this issue.

feat: support function fetchmany() and fetchall() in python SDK and UT
2 participants
@tobegit3hub @HuilinWu2