Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe and SmoothWave default effects are not smooth #184

Open
02tz opened this issue Jan 2, 2025 · 1 comment
Open

Swipe and SmoothWave default effects are not smooth #184

02tz opened this issue Jan 2, 2025 · 1 comment

Comments

@02tz
Copy link

02tz commented Jan 2, 2025

Rather than a swiping motion, the animation fades a stage to the chosen color then fades back to black individually, with no cohesion. There is also a slight flicker with color white. The christmas effect has a better swipe animation, and it will be linked below compared to the default swipe effects.

Swipe with color red on stage 1, speed 3:
https://drive.google.com/file/d/1wx0kUgqMpwZ7DfLJOwIU50HCOIrBvWWL/view?usp=drive_link

Replaced with white:
https://drive.google.com/file/d/1GHlmvkCSY5F0zpL_uai48AYqo15A8PJy/view?usp=sharing

SmoothWave on speed 3:
https://drive.google.com/file/d/1G4eAZsRp89Err6qmGf4dPK49Abzj7HmQ/view?usp=drive_link

Swipe animation present in the christmas effect:
https://drive.google.com/file/d/1EBSg2iY1gHNeMxTih8D4AKUkfWFfF0hw/view?usp=sharing

@4JX
Copy link
Owner

4JX commented Jan 2, 2025

Rather than a swiping motion, the animation fades a stage to the chosen color then fades back to black individually, with no cohesion. The christmas effect has a better swipe animation, and it will be linked below compared to the default swipe effects.

They work slightly differently. Swipe does as you say, switching the color you define on each zone to the next with a transition. The Christmas part you're showing first fills up the entire keyboard with one solid color, and then clears it out.

SmoothWave is a Swipe with preset colors for convenience, hence why it behaves similarly.

I can probably work the Christmas variant into it's own thing, or better yet allow to precisely select one subeffect to achieve the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants