fix(serializer/types): Allow null value in serializer for parsers with default values
#769
Conversation
|
@MartinCura is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franky47
added
the
deploy:preview
commit: |
|
Feel free to test the pkg.pr.new build to see if it works on your side. |
franky47
changed the title
null to serialize param whose parser has defaultnull in serializer for parsers with default values
franky47
changed the title
null in serializer for parsers with default valuesnull value in serializer for parsers with default values
It does remove the type error ✅ I didn't see a changelog file so only thing i may be missing is being explicit about this in the docs, maybe, though not necessary. Other than that, feel free to merge 🚀 |
|
The changelog is generated by semantic-release in the GitHub release when the package gets published. I think we can omit the docs, this is the expected behaviour. Thanks again for your contribution! 🙏 |
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
See related discussion.
Passing
nullto the serialize of a search param whose parser has a default currently is a type error, even though the behaviour works as expected.This is because for the values argument it infers the types using the same
inferParserTypewhich is fine for parsing but is not quite right for serializing. The way i'm fixing it is just declaring a differentinferSerializerRecordTypeto be used here. If there's some TS-foo i don't know which allows reusing the sameinferParserRecordType, that'd be even better!CONTRIBUTING.mdmentions "adding a minimal reproduction in the playground can be very helpful" but i couldn't immediately find how to create one there.Added some very basic tests, feel free to point out if any more would be nice.