Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add parseAsISODate #707

Merged
merged 5 commits into from
Oct 26, 2024
Merged

feat: Add parseAsISODate #707

merged 5 commits into from
Oct 26, 2024

Conversation

tylersayshi
Copy link
Contributor

follow up to #705

@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024

@tylersayshi is attempting to deploy a commit to the 47ng Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 6:44am

franky47
franky47 requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@franky47 franky47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of nitpicks on the docs integration, but this looks good!

packages/docs/content/docs/parsers/built-in.mdx Show resolved Hide resolved
packages/docs/content/docs/parsers/demos.tsx Outdated Show resolved Hide resolved
packages/nuqs/src/parsers.test.ts Outdated Show resolved Hide resolved
packages/nuqs/src/parsers.ts Outdated Show resolved Hide resolved
franky47
franky47 requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@franky47 franky47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd rather keep the iso query key for the datetime parser to avoid potential URL breakage.

I forgot I had Prettier disabled for MDX locally, I'll have to put that in the config. Not a big deal, we'll see if it creates formatting issues with the preview deployment.

packages/docs/content/docs/parsers/demos.tsx Outdated Show resolved Hide resolved
packages/nuqs/src/parsers.ts Outdated Show resolved Hide resolved
@tylersayshi
Copy link
Contributor Author

tylersayshi commented Oct 25, 2024 •
edited
Loading

I forgot I had Prettier disabled for MDX locally, I'll have to put that in the config. Not a big deal, we'll see if it creates formatting issues with the preview deployment.

I had been saving without formatting before then accidentally let it format. Would you like me to revert that?

tylersayshi and others added 2 commits October 25, 2024 16:07
franky47
franky47 approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@franky47 franky47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Tyler!

@franky47 franky47 enabled auto-merge (squash) October 26, 2024 06:41
@franky47 franky47 merged commit 107fcc1 into 47ng:next Oct 26, 2024
22 checks passed
@franky47
Copy link
Member

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

@franky47 franky47 mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franky47 franky47 franky47 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylersayshi @franky47