Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce users to declare a name for every DataSource #77

Closed
ghost opened this issue Nov 8, 2016 · 0 comments
Closed

Enforce users to declare a name for every DataSource #77

ghost opened this issue Nov 8, 2016 · 0 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Nov 8, 2016

Since it turns out that there is no way to get a unique name with the current class name approach, we should require DataSource implementations to define the name method from now on.
@ghost ghost added the bug Something isn't working label Nov 8, 2016
ghost pushed a commit that referenced this issue Nov 21, 2016
Make DataSource#name mandatory
ea8bf3f 
Closes #77
@ghost ghost mentioned this issue Nov 21, 2016
Merged
ghost pushed a commit that referenced this issue Nov 23, 2016
Make DataSource#name mandatory
27d328d 
Closes #77
@ghost ghost closed this as completed in #89 Nov 29, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants