Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of unwrap() in tests and codebase #90

Open
46ki75 opened this issue Nov 30, 2024 · 0 comments
Open

Eliminate use of unwrap() in tests and codebase #90

46ki75 opened this issue Nov 30, 2024 · 0 comments
Assignees
Labels

Comments

@46ki75
Copy link
Owner

46ki75 commented Nov 30, 2024

Currently, the project uses unwrap() extensively, including within test code. While unwrap() is often used in tests for simplicity, it's not ideal as it causes panics when the value is None or Err.

We would like to eliminate the use of unwrap() and replace it with expect() in the test code to provide more helpful error messages in case of failure. Additionally, unwrap() should be removed from the core codebase to avoid unnecessary panics, improving the robustness of the application.

The goal is to:

  • In tests: Replace unwrap() with expect() to ensure clear error messages in case of failure.
  • In the codebase: Avoid using unwrap() and handle errors more gracefully, using proper error handling strategies where appropriate.
@46ki75 46ki75 added this to the v1.0.0 Release milestone Nov 30, 2024
@46ki75 46ki75 self-assigned this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant