Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manage XMPP Pings (direct messages) #161

Closed
zino73 opened this issue May 6, 2017 · 5 comments
Closed

manage XMPP Pings (direct messages) #161

zino73 opened this issue May 6, 2017 · 5 comments
Labels
enhancement New feature or request

Comments

@zino73
Copy link

zino73 commented May 6, 2017

hello,

Im trying to get pings from a Xmpp server to discord channel using matterbridge. i already can get channel (groupchat) XMPP message, but unable to do the same with the XMPP pings probably because they are sended to everyone and no in a channel.

so i looked in xmpp.go file and i noticed that matterbridge catch only the type "groupchat":

if v.Type == "groupchat"

Is it planned to manage other type?
@zino73 zino73 changed the title managing XMPP Pings manage XMPP Pings May 6, 2017
@42wim
Copy link
Owner

42wim commented May 6, 2017

What exactly do you mean with XMPP ping ? Do you mean https://xmpp.org/extensions/xep-0199.html ?

@42wim 42wim added the waiting for feedback Further information is requested label May 6, 2017
@zino73
Copy link
Author

zino73 commented May 6, 2017 •
edited
Loading

yeah i think but im not sure but i already see the message in the command window but it is not routed to discord. this a sample of the message called "ping" and i want it to be routed :
<message to="[email protected]/id" type="chat" xml:lang="en" from="[email protected]/NAME"><body>The body messsafe</body></message>

@42wim
Copy link
Owner

42wim commented May 6, 2017

Ok, that looks like a private message, that will not be bridged
Matterbridge only relays public channel messages at this time.

@zino73
Copy link
Author

zino73 commented May 7, 2017 •
edited
Loading

ok thanks ill try to updade the code soon to manage chat message too. can you tag this like an enhancement?

@42wim 42wim added enhancement New feature or request and removed waiting for feedback Further information is requested labels May 8, 2017
@42wim 42wim changed the title manage XMPP Pings manage XMPP Pings (direct messages) Jul 8, 2017
@42wim
Copy link
Owner

42wim commented Jul 8, 2017

I'm going to close this, more general issue in #191

@42wim 42wim closed this as completed Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@42wim @zino73