Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remember user not working #31

Closed
BAKTETE opened this issue Oct 17, 2017 · 7 comments
Closed

remember user not working #31

BAKTETE opened this issue Oct 17, 2017 · 7 comments

Comments

@BAKTETE
Copy link

BAKTETE commented Oct 17, 2017

After installing the package the remember me stopped working i doubled checked but same scenario happens

@drbyte
Copy link
Contributor

drbyte commented Oct 17, 2017

Agreed.
They made some improvements after I reported it in #11
But the problem still persists:

  • "impersonated" session will log out after it expires, regardless of Remember Token.
  • after leaving impersonation, "impersonator's" session will also log out after it expires, regardless of Remember Token

@MarceauKa
Copy link
Member

Does the tests pass in your project? (this one)

@drbyte
Copy link
Contributor

drbyte commented Oct 31, 2017

Upon impersonation, the remember_web_zzzzzzzzzzzzzzzz cookie is deleted from the browser, despite the login_web_zzzzzzzzzzzzzz still being present in the app's session store.

Without the remember cookie, when the session actually does expire, the browser can't negotiate to revive the remember-ed session.

The provided tests pass, but the tests don't test this factor.

@Livijn
Copy link
Contributor

Livijn commented Apr 30, 2019

I'm having the same issue.

@MarceauKa
Copy link
Member

Ok, I'll try to replicate. Any ideas?

@Livijn
Copy link
Contributor

Livijn commented Apr 30, 2019

I have double checked what drbyte wrote, and it is true as well. I'm not sure whether you are required to delete that cookie in order to impersonate another user. I guess that is why you are deleting it, but in case it is not required – just don't delete it. 🤙

However, a naive way of solving this would be instead of deleting the cookie, you just rename it to temp_remember_web_xxxxxxx. Then upon "revert", you revert the name change. This would requiring always using the revert option unless we added some middleware checking for this temp cookie.

@MarceauKa
Copy link
Member

See the 1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants