Merge pull request #55 from 3scale/backport-52

backport-52 fix: old 3scale releases returned 404 Not found on backend endpoints
3scale-labs · Oct 15, 2020 · fce58e3 · fce58e3
2 parents 8ac3b8f + b9bb323
commit fce58e3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/buddhi/lib/amp/toolkit/buddhi/profiles/simple.rb b/buddhi/lib/amp/toolkit/buddhi/profiles/simple.rb
@@ -31,7 +31,7 @@ def self.call(portal, endpoint)
             begin
               backend = ThreeScale::Helper.create_backend(client, endpoint)
               ThreeScale::Helper.create_backend_usage(client, service, backend, '/')
-            rescue ::ThreeScale::API::HttpClient::ForbiddenError
+            rescue ::ThreeScale::API::HttpClient::ForbiddenError, ::ThreeScale::API::HttpClient::NotFoundError
               # 3scale Backends not supported
               ThreeScale::Helper.update_private_endpoint(client, service, endpoint)
             end

diff --git a/buddhi/lib/amp/toolkit/buddhi/service.rb b/buddhi/lib/amp/toolkit/buddhi/service.rb
@@ -53,7 +53,7 @@ def backend_mapping_rules
 
         def backend_usages
           client.list_backend_usages(service_id)
-        rescue ::ThreeScale::API::HttpClient::ForbiddenError
+        rescue ::ThreeScale::API::HttpClient::ForbiddenError, ::ThreeScale::API::HttpClient::NotFoundError
           # 3scale Backends not supported
           []
         end