Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from Bootstrap 2 to Bootstrap 5 - List changes #4861

Open
mdouchin opened this issue Oct 9, 2024 · 2 comments
Open

Migration from Bootstrap 2 to Bootstrap 5 - List changes #4861

mdouchin opened this issue Oct 9, 2024 · 2 comments

Comments

@mdouchin
Copy link
Collaborator

mdouchin commented Oct 9, 2024

This ticket aims to list all the changes to make in HTML code (in LWC source code but also in user-defined HTML, for example for popups with QGIS tooltips)

First migration made in this PR : #4455

We need to fix the issues as we spot them, and should also have a look to the external modules, external JavaScript scripts, etc.

Tables

  • condensed table : replace <table> class table-condensed by table-sm

Buttons

  • smaller buttons: replace <button> class btn-small by btn-sm
  • really smaller buttons: class btn-mini does not exists anymore ! See https://getbootstrap.com/docs/5.3/components/buttons/#sizes We could have kept btn-mini class in the code and add a Lizmap CSS variable --bs-btn-padding-y: .25rem; --bs-btn-padding-x: .5rem; --bs-btn-font-size: .75rem;" (values not tested)

Tabs

Doc:

Modal

Popups and dataviz

Forms

They seem really broken at present in master

@Gustry Gustry transferred this issue from 3liz/lizmap-plugin Oct 9, 2024
@mdouchin
Copy link
Collaborator Author

mdouchin commented Oct 9, 2024

cc @nboisteault @rldhont @Gustry @nworr @mind84

@mdouchin mdouchin pinned this issue Oct 9, 2024
@ygorigor
Copy link
Contributor

ygorigor commented Oct 10, 2024

Also progress is not showing (is not animated) when loading dataviz plot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants