Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer panel, group visibility #437

Open
Gustry opened this issue Aug 3, 2022 · 6 comments
Open

Layer panel, group visibility #437

Gustry opened this issue Aug 3, 2022 · 6 comments
Labels

Comments

@Gustry
Copy link
Member

Gustry commented Aug 3, 2022

Description

In the "Layer panel", then "group visibility", it's supposed to be a comma separated list of group IDs.

Always append a comma at the end of the string if it's missing ?

There is an issue we write only admin. The visibility is not working.
But it's working nicely if we do admin,

CC @rldhont @mdouchin Do you confirm ?

@rldhont
Copy link
Contributor

rldhont commented Aug 4, 2022

The extra comma has not to be required. Is the bug in lizmap web client or in lizmap server plugin ?

@gioman
Copy link

gioman commented Mar 20, 2023

Also note that in the last version of the plugin, adding a list pf groups with

image

do not work, meaning that after closing and reopening the plugin the list is gone.

@gioman
Copy link

gioman commented Mar 20, 2023

But it's working nicely if we do admin,

There is an issue we write only admin. The visibility is not working.
But it's working nicely if we do admin,

latest version of LMWC and LM plugin, it only works when the list does NOT ends with a comma.

@Gustry
Copy link
Member Author

Gustry commented Mar 20, 2023

Thanks for searching and reminding me this ticket, indeed.

I let a comment when merging this wizard : #460 (comment)

This comma hack has been a anti pattern and we wanted to do something meaningful.

@nboisteault
Copy link
Member

Also note that in the last version of the plugin, adding a list pf groups with

image

do not work, meaning that after closing and reopening the plugin the list is gone.

I also noticed this issue but only for layer groups

simplescreenrecorder-2024-01-09_18.26.43.mp4

@Gustry
Copy link
Member Author

Gustry commented Jan 9, 2024

@nboisteault It's different issue according to your screencast ;-)
Fixed in master, commit 8a644a2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants