Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test application crashes when playing with multiple sources and convolutional reverb #25

Open
areyesl opened this issue Mar 23, 2024 · 0 comments

Comments

@areyesl
Copy link
Contributor

areyesl commented Mar 23, 2024

Actions to crash:

  • Open a second source
  • Play both
  • Disable convolutional reverb
  • Stop one of the sources
  • Enable convolutional reverb again ---> crash

It seems that when reverb is disabled, ir remembers that two sources were being included in the reverb. Then, when it is enabled again, only one is active and that seems to create a conflct.

More specifically, the problem occurs when two sources are loaded and one of them is stopped. The loop in CEnvironment::ProcessVirtualAmbisonicReverbThreedimensional() iterates through all sources, not only those being played.

In Environment.cpp, line 1032, it is checked if every source has updated the buffer. When a source is stopped, it doesn't update the buffer, but this control prevents the crash. However, when the reverb is switched on, in the first frame, this control fails and the app crashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant