Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use c-frame cursor teleport #270

Closed
kfarr opened this issue Apr 19, 2023 · 1 comment
Closed

use c-frame cursor teleport #270

kfarr opened this issue Apr 19, 2023 · 1 comment
Assignees
@vincentfretin

Comments

@kfarr
Copy link
Collaborator

kfarr commented Apr 19, 2023 •
edited
Loading

We can now leverage the C-Frame maintained cursor teleport component. The customized version here: https://github.com/kfarr/aframe-cursor-teleport should no longer be needed to support our features.

Also review this PR to test ipad cursor visibility change:
c-frame/aframe-cursor-teleport#57
@kfarr kfarr converted this from a draft issue Apr 19, 2023
@kfarr kfarr changed the title review and migrate cursor changes use c-frame cursor teleport Apr 19, 2023
@kfarr kfarr moved this from For Review to To Do in 3DStreet Dev Tracking Apr 19, 2023
@vincentfretin
Copy link
Collaborator

c-frame/aframe-cursor-teleport#57 has been merged and I build new dist on master.
Your fork still contain some changes you may want to have upstream, those are:

@vincentfretin vincentfretin moved this from Backlog (Not Ready) to For Review in 3DStreet Dev Tracking Aug 12, 2024
@vincentfretin vincentfretin self-assigned this Aug 12, 2024
@kfarr kfarr closed this as completed in 557f427 Aug 12, 2024
@github-project-automation github-project-automation bot moved this from For Review to Done in 3DStreet Dev Tracking Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincentfretin vincentfretin

Labels
None yet
Projects
3DStreet Dev Tracking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincentfretin @kfarr