-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to install Tensorflow and Keras for Python and R #6
Comments
The latest versions are fine according to the requester. |
That is the time expectation I got from them. |
Copy-pasting what I have written on Slack:
|
Opened an exploratory PR at #7 to build things in several steps. |
Update: I have tested the image I build in #7 in the staging hub under the 2i2c cluster (because I can not easily login into the UoT staging hub) and it seems to be working as expected from the Python side of things: I have built and run a notebook with some basic TF and Keras examples without issue (although with several warnings... it seems both TF and Keras are pretty verbose because you can actually install them in different configurations, ie. CPU vs GPU). |
OK, I tried installing the R requirements (tensorflow and keras R-based version... you actually need those counterparts that use the python stack under the hood) but now I am facing a failing pattern related to the fact I need to bump the version of other R packages (see my latest commits in the #7). This seems to be an "endless" pattern after several iterations, so I am wondering if others actually faced the same problem at the time to deal with this image. |
Doing some research I found this article: https://support.rstudio.com/hc/en-us/articles/219949047-Installing-older-versions-of-packages, which seems to indicate we would need to pass a URL to hit the old packages: $ git diff
diff --git a/install.R b/install.R
index 78bf356..77d5b8d 100755
--- a/install.R
+++ b/install.R
@@ -116,7 +116,8 @@ github_packages <- c(
for (i in seq(1, length(cran_packages), 2)) {
devtools::install_version(
cran_packages[i],
- version = cran_packages[i + 1]
+ version = cran_packages[i + 1],
+ repos = "http://cran.us.r-project.org"
)
} But in that case, I would be worried about future incompatibilities (as the article indicated at the end):
|
@damianavila, yes, I believe I kept bumped versions until it worked. Although I don't remember going into this many steps :(
So the place where the R pkgs get installed from is the Rstudio pkg manager: Lines 1 to 2 in fa7eef0
And I believe that's because it can provide binary pkgs rather than just from source files. |
Thanks for the additional context, @GeorgianaElena! It seems the Rstudio pkg manager actually offers a way to "freeze" the package set you can fetch from but that would not play well with new libraries (when we need to install new ones). I will try to sync the packages we currently have in file with the latest one from the RStudio package manager and see how that goes... |
Independently of how it goes, I think we need to re-think how we are creating and maintaining the R environment because otherwise, we are going to have this version jumps in multiple packages any time we might need to add some new dependencies and that could be an unstable territory from the user perspective, IMHO. |
Btw, for future readers, these are the related PRs workarounding the issue at the time to test in Binder (not possible) and the repo2docker timeout (I have already merged both those along the way): |
The last try (syncing all the versions) seemed to work. I was able to build a test image and tested some basic TF and Keras commands and it seems to work. |
Done! Thanks a lot, @damianavila! |
Thanks for the merge, @yuvipanda. |
Unfortunately actually attempting to use these libraries doesn't work: If you set
which makes me suspect and fear that the issue is that R and python are using different openssl libraries... |
I did not need to add the RETICULATE_PYTHON before... not sure why this is not working now, although I suspect the image is actually a little bit different now since the last time I tested. |
Update of the whole situation (and also draft to be posted to the Jupyter discourse forum): Openssl mismatch between RStudio and conda environments
|
@choldgraf, this is the draft for the Jupyter discourse post we talked about yesterday. @2i2c-org/tech-team, feel free to comment about the draft as well! |
@damianavila I added a few quick edits above. I think in general it looks good to me! Quick thought on structure, but I think we can probably send it off quickly after that: I think that the post should go from "most general" to "most technical". Most people are going to start reading at the top and lose steam by the time they read 100-150 words, unless they are very motivated. So I think we should put the most actionable and important stuff at the top. To that extent, I'd structure it like:
I think the stuff like "confirming which version of OpenSSL" is really nice, but doesn't answer the question people will have of "ok but what do I actually do about this?". So I think we could put that information at the bottom for people who really want to learn more. |
Thanks for the feedback, @choldgraf!
OK, I will try your structure and ping you back again when it is ready so you can quickly look at it before posting it. |
@choldgraf, I think this new layout adheres to your last request. Openssl mismatch between RStudio and conda environments
|
Jupyter Discourse post was published here: https://discourse.jupyter.org/t/openssl-mismatch-between-rstudio-and-conda-environments/14123 |
Pinged Nathan on the ticket: https://2i2c.freshdesk.com/a/tickets/65?note=80136454078. Closing this one now. |
This is a request coming from a Freshdesk support ticket: https://2i2c.freshdesk.com/a/tickets/65
We had a conversation in Slack about this one and we decided we are going to implement the update (instead of the user itself) because of the inherent complexity at the time to install those libraries.
The timeline and specific versions are not clear yet but I already have requested that information.
The text was updated successfully, but these errors were encountered: