Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More thorough automated dask testing #771

Closed
sgibson91 opened this issue Oct 22, 2021 · 4 comments · Fixed by #776
Closed

More thorough automated dask testing #771

sgibson91 opened this issue Oct 22, 2021 · 4 comments · Fixed by #776
Assignees
Labels
Task Actions that don't involve changing our code or docs.

Comments

@sgibson91
Copy link
Member

sgibson91 commented Oct 22, 2021

Description

We wanted to make sure that the options listed in the following docs were all working on the Pangeo deployment before we go live with the prod hub: https://pangeo.io/cloud.html#dask Since these are quite generic tests of dask (e.g. don't require requester pays access to data, etc), it would be nice to add them to our daskhub tests so we can verify the scaling of all our daskhubs and be alerted to any issues. Our current test only tests local dask right now.

Value / benefit

  • We can be confident in the performance of our daskhubs with little human effort
  • We can be alerted to issues with our daskhubs with little human effort

Implementation details

I would expect there to be a check that the dask scheduler and worker pods were correctly created in the namespace and I'm not sure how to write that test

Tasks to complete

No response

Updates

No response

@damianavila
Copy link
Contributor

I would expect there to be a check that the dask scheduler and worker pods were correctly created in the namespace and I'm not sure how to write that test

What about looking for some end result in the notebook that assures us the scheduler and the worked pods were created and worked as expected? Would not be that an easier test to write, perhaps?

@sgibson91
Copy link
Member Author

This is Pangeo's current testing infrastructure:

https://github.com/pangeo-data/pangeo-cloud-federation/blob/staging/test.py

https://github.com/pangeo-data/pangeo-cloud-federation/blob/staging/run_tests.sh

@damianavila
Copy link
Contributor

We already have the machinery to run tests so I guess it is a matter to include/adapt test.py into a test notebook, maybe?

@sgibson91
Copy link
Member Author

Yep. I'll look into it once I've babysat the Auth0 stuff :)

@sgibson91 sgibson91 self-assigned this Oct 25, 2021
@sgibson91 sgibson91 linked a pull request Oct 25, 2021 that will close this issue
@sgibson91 sgibson91 moved this to Todo 👍 in Sprint Board Oct 25, 2021
@sgibson91 sgibson91 moved this from Todo 👍 to Needs input 🙌 in Sprint Board Oct 27, 2021
@sgibson91 sgibson91 moved this from Todo to In Progress in DEPRECATED Engineering and Product Backlog Oct 27, 2021
Repository owner moved this from In Progress to Done in DEPRECATED Engineering and Product Backlog Oct 29, 2021
Repository owner moved this from Needs input 🙌 to Done 🎉 in Sprint Board Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Actions that don't involve changing our code or docs.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants