Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirecting the test output (to prevent the CI from leaking secrets) is preventing us to get the actual error locally #694

Closed
1 of 2 tasks
damianavila opened this issue Sep 21, 2021 · 3 comments · Fixed by #712
Assignees

Comments

@damianavila
Copy link
Contributor

damianavila commented Sep 21, 2021

Description

I faced this issue investigating failures at the time to deploy openscapes.
More details here: #691 (comment)

Value / benefit

We should be able to easily get the test output when we are working locally whereas we redirect the output in the CI environment.

Implementation details

A proposal lives in this comment: #691 (comment) (check diff) and people showed interest to have this piece as a new PR.

Tasks to complete

  • PR diff with the proposed implementation
  • Discuss details about the env variable that we may use to detect the GitHub env

Updates

No response

@sgibson91
Copy link
Member

I am +1 on the suggested change change you showed in the comment. @yuvipanda and I also discussed about not running the tests with pytest at all as we use none of it's functionality. Instead, just call it as a normal function.

@choldgraf
Copy link
Member

Added to the sprint board since @damianavila mentioned he wanted to tackle this in our team update

@damianavila
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants