You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #1938@sgibson91 correctly pointed out the naming of the files and possible their location in deployer/grafana and deployer/generate might need more thought put into it.
Proposal
Reflect over the design of:
deployer/grafana
deployer/generate
deployer/utils.py
Updates and actions
No response
The text was updated successfully, but these errors were encountered:
I have a small wondering on file naming. For example, now that we have a grafana subfolder, I would say that grafana/utils.py and grafana/manage_tokens.py would reduce redundancy compared to grafana/grafana_utils.py and grafana/grafana_tokens.py etc, particularly when importing, i.e. from grafana import utils versus from grafana import grafana_utils. In the utils-specific case we'd need to avoid naming clashes with the top-level utils though. Which indicates to me either (i) we are overusing utils and should be more creative in our filenaming, or (ii) I am overthinking package design :D
Context
In #1938 @sgibson91 correctly pointed out the naming of the files and possible their location in
deployer/grafana
anddeployer/generate
might need more thought put into it.Proposal
Reflect over the design of:
deployer/grafana
deployer/generate
deployer/utils.py
Updates and actions
No response
The text was updated successfully, but these errors were encountered: