Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyterhub_config.py should include inline comment its not loaded in production - only for testing #27

Open
consideRatio opened this issue Sep 1, 2023 · 0 comments

Comments

@consideRatio
Copy link

Is it correct that a 2i2c deployed jupyterhub won't load the jupyterhub_config.py file in this repo, and that its only around in order to help users test how things look locally as mentioned in the README?

I think so, but I'm not sure. If that is the case, we should make sure to inline comments about that in the jupyterhub_config.py, and clarify that such config needs to be passed via the 2i2c chart config directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Needs Shaping / Refinement
Development

No branches or pull requests

1 participant