TypeError: unsupported operand type

[chrishat34]

error-2022-02-21_19-37-15.txt

[2e0byo]

oops. Should be elapsed.seconds. Will fix.

[chrishat34]

as this:
subtract = elapsed.seconds if elapsed else 0
#jch added .seconds
return max(self.period * 60 - elapsed.seconds, 0)

[2e0byo]

Yes exactly. Madly busy atm: if you PR that I'll merge it. Otherwise I'll get at the codebase in a few days. This is where YADC suffers from the lack of a decent testsuite: that's the kind of typo which really should be been caught earlier...

[2e0byo]

Note that I was not quite right:

        subtract = elapsed.seconds if elapsed else 0
        return max(self.period * 60 - subtract, 0)

The first line works out how much to subtract to take into account the runtime of the last run, ignoring elapsed if it wasn't passed (it's optional); the second returns how many seconds to sleep to make up the required time, capping the duration at zero since we can't go back in time if the run took longer than it should have.

The solution above (elapsed.seconds) will fail if elapsed is not passed. I believe all the code in this repo actually does pass it, so the issue is trivial.

[chrishat34]

nice one - thank you