-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifacts after update to 1.17 #253
Comments
To add to this, I am also experiencing this exact artifacting on iOS devices after upgrading Flutter to 1.17. All pre-existing animations with ellipses were affected. I feel like this is probably related to Flutter 1.17 moving to Metal from OpenGL? |
Thanks for the report! Could you provide an example Rive file for us to test? |
@umberto-sonnino Please note, You can see this bug only on real iOS devices. Thanks. |
So we've taken a look at this, and we can see the artifacts too -- but only while drawing paths on Flutter Stable. In fact, running that same file on the Flutter Dev channel it draws fine. |
@umberto-sonnino can confirm the precense of the artifacts on the current master head. One thing for you to note: artifacts are gone without antialias. This actually kinda needs severe fixing. Animation a tested with: See videos: |
Would you mind providing a repro? |
@umberto-sonnino can you please try and run my animation, not the code from the issue. Thanks in advance for understanding. |
@umberto-sonnino re-read my comment and rewatch the video I attached. artifacts occur with only specific small sizes of the animation canvas. constrain it to for example 20 pixels and check what happens i encountered jagged, triangle shapes round the bars when animation was playing |
@umberto-sonnino how it should look (and looks properly without anti-aliasing) vs how it actually looks with anti-aliasing |
@umberto-sonnino any updates? |
@nt4f04uNd I was able to reproduce the issue with the steps you mentioned, but not isolate it yet! |
@umberto-sonnino will this be fixed? I have an application to release and I will have to do that with this bug if this isn't adressed in the next few days |
Hey @nt4f04uNd, I've finally isolated the issue, and this might be related to a number of causes: turning on antialiasing, applying a transform with non-uniform scaling, using a big stroke, and rendering the shape in a small space, like your 35x35 container above. A first workaround you could try is to deform vertices to obtain the same effect, instead of using big stroke values in your animations. I'll also report this back to the Flutter team to see if there's anything that can be done. |
@umberto-sonnino LOL the solution was so simple you can't even imagine. I just changed stroke join to be rounded, can't believe that worked. That behaviour (with other join options as I had initially) is still a bug I guess, as it shouldn't produce such weird shapes. |
flutter/flutter#57959
The text was updated successfully, but these errors were encountered: