Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscribe fails HARD #327

Open
hurricaneJoef opened this issue Jun 23, 2024 · 2 comments
Open

subscribe fails HARD #327

hurricaneJoef opened this issue Jun 23, 2024 · 2 comments

Comments

@hurricaneJoef
Copy link

I noticed you have it set up if the mqtt client fails when subscribing to a topic (like a topic already subscribed to) it closes the connection to the server.

is this intentional?
if so can an alternative function be added to not close in this way?

(I have already fixed after a long effort server side this so I can submit a pr if it would be wanted)

@wagfeliz
Copy link

I am getting this issue also...

@256dpi
Copy link
Owner

256dpi commented Aug 30, 2024

Yes, until now we followed a fail hard mantra when it comes to protocol level errors. I'm happy to review pull requests that soften that a bit for more advanced use cases. May we can add a client.setSoftFail(bool) method that sets an internal variable that does not close the connection on such errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants