Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last / second last chunk size issues #180

Closed
eklann opened this issue Jul 20, 2014 · 3 comments
Closed

Last / second last chunk size issues #180

eklann opened this issue Jul 20, 2014 · 3 comments

Comments

@eklann
Copy link

eklann commented Jul 20, 2014

It seems like the second last chunk is often more than resumableChunkSize bytes. It seems like the data that should be in the second last chunk and the last chunk are concatenated into the second last chunk, and the last one is sent as well.

If i just put all the pieces together without taking this into account, I will end up with a file bigger then the one i sent (the data in the last chunk is replicated once in the end).

This seems like a bug. Either the last chunk should never be sent, or (more reasonable) the second last chunk should be of size resumableChunkSize.

I am using the latest from the master branch, and resumableChunkSize = 512 * 1024. I get this bug with all tested files with sizes above resumableChunkSize.

@eklann
Copy link
Author

eklann commented Jul 20, 2014

Using forceChunkSize: true fixes the size of the second last chunk, but with this option disabled the last chunk is sent even though the data in it is already sent in the second last chunk.

@steffentchr
Copy link
Member

Please refer to #51 for a discussion of and explanation for this behaviour. There are reasons.

@eklann
Copy link
Author

eklann commented Jul 21, 2014

I cannot see a reason for uploading the same data twice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants