Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static typing for docs #147

Merged
merged 16 commits into from
Aug 29, 2022
Merged

Add static typing for docs #147

merged 16 commits into from
Aug 29, 2022

Conversation

1kastner
Copy link
Owner

No description provided.

@1kastner 1kastner changed the title Link to python types Add static typing linting Aug 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022

Codecov Report

Merging #147 (f493820) into main (aef3489) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   94.57%   94.59%   +0.01%     
==========================================
  Files         111      111              
  Lines        4019     4033      +14     
==========================================
+ Hits         3801     3815      +14     
  Misses        218      218              
Impacted Files Coverage Δ
...nalyses/container_flow_by_vehicle_type_analysis.py 100.00% <ø> (ø)
conflowgen/analyses/yard_capacity_analysis.py 97.14% <ø> (ø)
...n/api/container_dwell_time_distribution_manager.py 100.00% <ø> (ø)
...onflowgen/api/container_flow_generation_manager.py 96.55% <ø> (ø)
conflowgen/api/database_chooser.py 93.33% <ø> (ø)
conflowgen/api/export_container_flow_manager.py 58.33% <ø> (ø)
conflowgen/api/port_call_manager.py 94.44% <ø> (ø)
...lication/services/export_container_flow_service.py 65.73% <ø> (ø)
conflowgen/descriptive_datatypes/__init__.py 100.00% <ø> (ø)
...owgen/domain_models/data_types/container_length.py 90.00% <ø> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Aug 29, 2022

This pull request introduces 2 alerts when merging 77a8b0c into bf063cb - view on LGTM.com

new alerts:

  • 2 for Unused import

@1kastner 1kastner changed the title Add static typing linting Add static typing for docs Aug 29, 2022
@1kastner
Copy link
Owner Author

1kastner commented Aug 29, 2022

These remain problematic:

Furthermore, the CSS styling is more like an interims solution.

@1kastner 1kastner marked this pull request as ready for review August 29, 2022 12:08
@1kastner 1kastner merged commit 3f38c7f into main Aug 29, 2022
@1kastner 1kastner deleted the link-to-python-types branch August 29, 2022 12:38
@lgtm-com
Copy link

lgtm-com bot commented Aug 29, 2022

This pull request introduces 1 alert when merging f493820 into aef3489 - view on LGTM.com

new alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants