Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittest for DatabaseChooser to check for opening/closing behavior #45

Open
1kastner opened this issue Jan 14, 2022 · 1 comment
Open

Add unittest for DatabaseChooser to check for opening/closing behavior #45

1kastner opened this issue Jan 14, 2022 · 1 comment
Labels
good first issue Good for newcomers technical-debt This increases the code quality without changing the functionality

Comments

@1kastner
Copy link
Owner

1kastner commented Jan 14, 2022 •
edited
Loading

The class is currently poorly covered. There should be either no or a single open connection to an SQL database. We should never happen to work with a closed connection object. This should be checked by using mocking - see https://docs.python.org/3/library/unittest.mock.html for reference.
@1kastner 1kastner added good first issue Good for newcomers technical-debt This increases the code quality without changing the functionality labels Jan 14, 2022
@1kastner
Copy link
Owner Author

See https://app.codecov.io/gh/1kastner/conflowgen for the current coverage.

@1kastner 1kastner changed the title Add test for DatabaseChooser to check for opening/closing behavior Add unittest for DatabaseChooser to check for opening/closing behavior Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers technical-debt This increases the code quality without changing the functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1kastner