Методы расширения протокола для предоставления информации дебаг адаптеру #3342

akpaevj · 2024-09-12T19:17:57Z

Описание

Связанные задачи

Closes

Чеклист

Общие

Ветка PR обновлена из develop
Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
Изменения покрыты тестами
Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Дополнительно

coderabbitai · 2024-09-12T19:18:05Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

theshadowco · 2024-09-25T16:53:13Z

src/main/java/com/github/_1c_syntax/bsl/languageserver/jsonrpc/ModuleInfo.java

+@Getter
+@ToString
+@EqualsAndHashCode
+public class ModuleInfo {


может record?

theshadowco · 2024-09-25T16:53:35Z

src/main/java/com/github/_1c_syntax/bsl/languageserver/jsonrpc/ModuleUri.java

+@Getter
+@ToString
+@EqualsAndHashCode
+public class ModuleUri {


theshadowco · 2024-09-25T16:56:25Z

src/main/java/com/github/_1c_syntax/bsl/languageserver/utils/ModuleTypePropertyIdMapper.java

+    entry(ModuleType.CommandModule, "078a6af8-d22c-4248-9c33-7e90075a3d2c"),
+    entry(ModuleType.CommonModule, "d5963243-262e-4398-b4d7-fb16d06484f6"),
+    entry(ModuleType.ObjectModule, "a637f77f-3840-441d-a1c3-699c8c5cb7e0"),
+    entry(ModuleType.ManagerModule, "d1b64a2c-8078-4982-8190-8f81aefda192"),
+    entry(ModuleType.FormModule, "32e087ab-1491-49b6-aba7-43571b41ac2b"),
+    entry(ModuleType.RecordSetModule, "9f36fd70-4bf4-47f6-b235-935f73aab43f"),
+    entry(ModuleType.ValueManagerModule, "3e58c91f-9aaa-4f42-8999-4baf33907b75"),
+    entry(ModuleType.ManagedApplicationModule, "d22e852a-cf8a-4f77-8ccb-3548e7792bea"),
+    entry(ModuleType.SessionModule, "9b7bbbae-9771-46f2-9e4d-2489e0ffc702"),
+    entry(ModuleType.ExternalConnectionModule, "a4a9c1e2-1e54-4c7f-af06-4ca341198fac"),
+    entry(ModuleType.OrdinaryApplicationModule, "a78d9ce3-4e0c-48d5-9863-ae7342eedf94"),
+    entry(ModuleType.HTTPServiceModule, "d5963243-262e-4398-b4d7-fb16d06484f6"),
+    entry(ModuleType.WEBServiceModule, "d5963243-262e-4398-b4d7-fb16d06484f6")


а что это за UID'ы?

Захардкоженные в платформе уиды типов модулей. На все осталные комменты - это не окончательная редакция (она уже сильно поменялась и подчищена, рекорды тоже сделаны), поэтому драфт

theshadowco · 2024-09-25T16:56:54Z

src/main/resources/com/github/_1c_syntax/bsl/languageserver/configuration/schema.json

@@ -951,4 +951,4 @@
            "default": "ask"
        }
    }
-}
+}


постороннее изменение

theshadowco · 2024-09-25T16:57:02Z

docs/en/diagnostics/DoubleNegatives.md

+<!-- Блоки выше заполняются автоматически, не трогать -->
+## Description
+
+# Double negatives (DoubleNegatives)
+


постороннее изменение

Методы расширения протокола для предоставления информации дебаг адаптеру

c18ae56

забыл precommit

e50851c

theshadowco reviewed Sep 25, 2024

View reviewed changes

akpaevj closed this Oct 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Методы расширения протокола для предоставления информации дебаг адаптеру #3342

Методы расширения протокола для предоставления информации дебаг адаптеру #3342

akpaevj commented Sep 12, 2024 •

edited

Loading

coderabbitai bot commented Sep 12, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

theshadowco Sep 25, 2024

theshadowco Sep 25, 2024

theshadowco Sep 25, 2024

akpaevj Sep 25, 2024 •

edited

Loading

theshadowco Sep 25, 2024

theshadowco Sep 25, 2024

Методы расширения протокола для предоставления информации дебаг адаптеру #3342

Методы расширения протокола для предоставления информации дебаг адаптеру #3342

Conversation

akpaevj commented Sep 12, 2024 • edited Loading

Описание

Связанные задачи

Чеклист

Общие

Дополнительно

coderabbitai bot commented Sep 12, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

theshadowco Sep 25, 2024

Choose a reason for hiding this comment

theshadowco Sep 25, 2024

Choose a reason for hiding this comment

theshadowco Sep 25, 2024

Choose a reason for hiding this comment

akpaevj Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

theshadowco Sep 25, 2024

Choose a reason for hiding this comment

theshadowco Sep 25, 2024

Choose a reason for hiding this comment

akpaevj commented Sep 12, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

akpaevj Sep 25, 2024 •

edited

Loading