Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Поддержка mdclasses 0.12 #3158

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Поддержка mdclasses 0.12 #3158

merged 3 commits into from
Dec 18, 2023

Conversation

theshadowco
Copy link
Member

@theshadowco theshadowco commented Oct 7, 2023 •
edited
Loading

Описание

Внесены изменения для поддержки mdclasses 0.12.

Не работает одна диагностика про пути формы, тесты отключены

Связанные задачи

Closes

Чеклист

Общие

  • Ветка PR обновлена из develop
  • Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
  • Изменения покрыты тестами
  • Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

  • Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

@ghost
Copy link

ghost commented Oct 7, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link

github-actions bot commented Oct 7, 2023 •
edited
Loading

Qodana Community for JVM

153 new problems were found

Inspection name Severity Problems
Constant values 🔶 Warning 40
Mismatched query and update of collection 🔶 Warning 20
Statement with empty body 🔶 Warning 5
'@Serial' annotation could be used 🔶 Warning 4
Infinite recursion 🔶 Warning 2
Suspicious collection method call 🔶 Warning 2
Class is exposed outside of its visibility scope 🔶 Warning 1
Nullability and data flow problems 🔶 Warning 1
Mismatched read and write of array 🔶 Warning 1
Constant values ◽️ Notice 77

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 7, 2023
View reviewed changes
.../com/github/_1c_syntax/bsl/languageserver/diagnostics/RedundantAccessToObjectDiagnostic.java Fixed Show fixed Hide fixed
...b/_1c_syntax/bsl/languageserver/diagnostics/ExecuteExternalCodeInCommonModuleDiagnostic.java Fixed Show fixed Hide fixed
...a/com/github/_1c_syntax/bsl/languageserver/diagnostics/WrongWebServiceHandlerDiagnostic.java Fixed Show fixed Hide fixed
.../com/github/_1c_syntax/bsl/languageserver/diagnostics/WrongHttpServiceHandlerDiagnostic.java Fixed Show fixed Hide fixed
...com/github/_1c_syntax/bsl/languageserver/diagnostics/AbstractCommonModuleNameDiagnostic.java Fixed Show fixed Hide fixed
...java/com/github/_1c_syntax/bsl/languageserver/diagnostics/ScheduledJobHandlerDiagnostic.java Fixed Show fixed Hide fixed
...in/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/AbstractMetadataDiagnostic.java Fixed Show fixed Hide fixed
src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/CachedPublicDiagnostic.java Fixed Show fixed Hide fixed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

87.8% 87.8% Coverage
0.0% 0.0% Duplication

@theshadowco theshadowco requested review from asosnoviy and nixel2007 and removed request for asosnoviy October 9, 2023 04:53
nixel2007
nixel2007 reviewed Oct 29, 2023
View reviewed changes
Copy link
Member

@nixel2007 nixel2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень приятные изменения, отличная работа!

@github-actions GitHub Actions
Copy link

Qodana Community for JVM

17 new problems were found

Inspection name Severity Problems
Statement with empty body 🔶 Warning 5
'@Serial' annotation could be used 🔶 Warning 4
Constant values 🔶 Warning 3
Mismatched query and update of collection 🔶 Warning 2
Class is exposed outside of its visibility scope 🔶 Warning 1
Nullability and data flow problems 🔶 Warning 1
Mismatched read and write of array 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

14 New issues
0 Security Hotspots
87.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@theshadowco theshadowco merged commit 0c544f4 into develop Dec 18, 2023
34 checks passed
@theshadowco theshadowco deleted the feature/newMDC branch December 18, 2023 16:16
@theshadowco theshadowco added this to the 0.23.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixel2007 nixel2007 nixel2007 left review comments

@asosnoviy asosnoviy Awaiting requested review from asosnoviy

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@theshadowco @nixel2007