Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow that worked with v0.3 but does not with v0.4 #5

Closed
tueda opened this issue Apr 5, 2024 · 3 comments · Fixed by #6
Closed

Workflow that worked with v0.3 but does not with v0.4 #5

tueda opened this issue Apr 5, 2024 · 3 comments · Fixed by #6

Comments

@tueda
Copy link

tueda commented Apr 5, 2024

The following usage of the action does not work with 0.4.2 (log) or 0.4.4 (log):

      - uses: 1arp/[email protected]
        with:
          file: foo.txt
          content: |
            Hello
            World
Error: ENOENT: no such file or directory, mkdir ''

Indeed, with 0.3 (log), this successfully creates foo.txt in the root of the repository directory.

@1arp
Copy link
Owner

1arp commented Apr 5, 2024

Hi @tueda,
Thanks for bringing this forward.
You are right it seems that the issue is related to actions/toolkit#361
I will patch this ASAP. ( ECD : end of this weekend )
Sorry for breaking your workflow.

The getInput function used to parse the new isAbsoluteParam parameter parses it as a string rather than a boolean, leading to reading the default value as a string which is truthy. The correct way to parse the input will be to use getBooleanInput.

@1arp
Copy link
Owner

1arp commented Apr 5, 2024

The issue should be fixed with latest 0.4.5 release

attaching run with latest release:
Screenshot 2024-04-05 at 22 23 53

@tueda
Copy link
Author

tueda commented Apr 5, 2024

Thank you for the prompt fix! I've confirmed that 0.4.5 works well (log).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants