-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIghlight key and value for "1Password: Save to 1Password" #140
Comments
Hi @cycle4passion, thanks for filing this ticket. Apologies it's taken a while to review it. I am trying to reproduce this issue and am having a different result:
If you're able to, can you try to reproduce your issue and outline the steps you took? Thank you! |
I agree, its been awhile. As I read what I wrote previously, I can't even understand it. I will try again. First off the the steps you propose do work. Lets start with a different example first // .env I highlight I am asked
Now second example. Assume this is the first time I have used this extension. // .env I highlight
|
Summary
let say I have an .env variable like
I highlight the
127.0.0.1:5000
part and invoke1Password: Save in 1Password
.What do you want to call it?
defaults to save inurl
, and I think thats sounds good. This process creates a standard 1Password item and does not replace the hardcoded selection. I see that not available through1Password: Get from 1Password
. Thereafter, I figure when asked for theWhat do you want to call it?
I put in PUBLIC_APP_URL.Proposed solution
When
1Password: Save to 1Password
is invoked, regex the selection to include the key if highlighted and load that for the default inWhat do you want to call it?
Also if the key is not highlighted change the default fromurl
to something likeUNDEFINED_KEY
in order to prevent user confusion as I had as above. This change (if key highlighted) would also require the selection be changed before replacing the hardcoded secret with the 1Password replacement.Is there a workaround to accomplish this today?
Already know
url
won't work (not in docs?) and manually type a new name.The text was updated successfully, but these errors were encountered: