-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add illustration to radio and checkbox tiles #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acknowledging that visual regression test will fail as we are adding a new checkbox and radio button tile. |
aduth
reviewed
Feb 15, 2022
jmdembe
force-pushed
the
jd-LG-5755-checkbox-tile
branch
from
February 15, 2022 18:22
ebc4c1d
to
431631a
Compare
aduth
reviewed
Feb 15, 2022
jmdembe
force-pushed
the
jd-LG-5755-checkbox-tile
branch
from
February 16, 2022 15:05
8139718
to
3b9a209
Compare
aduth
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍 Could you also include a note in the CHANGELOG.md file?
jmdembe
force-pushed
the
jd-LG-5755-checkbox-tile
branch
from
February 16, 2022 17:49
114141f
to
9282aff
Compare
Co-authored-by: Andrew Duthie <[email protected]>
Co-authored-by: Andrew Duthie <[email protected]>
jmdembe
force-pushed
the
jd-LG-5755-checkbox-tile
branch
4 times, most recently
from
February 16, 2022 18:12
a640755
to
8e819f4
Compare
jmdembe
force-pushed
the
jd-LG-5755-checkbox-tile
branch
from
February 16, 2022 18:13
8e819f4
to
33ecc3a
Compare
aduth
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an illustration to radio and checkbox tiles.
Why: To facilitate development of MFA checkboxes and radio labels