Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add illustration to radio and checkbox tiles #296

Merged
merged 19 commits into from
Feb 16, 2022
Merged

Conversation

jmdembe
Copy link
Contributor

@jmdembe jmdembe commented Feb 15, 2022

This PR adds an illustration to radio and checkbox tiles.

Why: To facilitate development of MFA checkboxes and radio labels

@jmdembe
Copy link
Contributor Author

jmdembe commented Feb 15, 2022

Acknowledging that visual regression test will fail as we are adding a new checkbox and radio button tile.

docs/_components/form-fields.md Outdated Show resolved Hide resolved
docs/_components/form-fields.md Outdated Show resolved Hide resolved
docs/_components/form-fields.md Outdated Show resolved Hide resolved
src/img/fingerprint-icon.svg Outdated Show resolved Hide resolved
src/scss/components/_inputs.scss Outdated Show resolved Hide resolved
src/scss/components/_inputs.scss Outdated Show resolved Hide resolved
src/scss/components/_inputs.scss Outdated Show resolved Hide resolved
@jmdembe jmdembe force-pushed the jd-LG-5755-checkbox-tile branch from ebc4c1d to 431631a Compare February 15, 2022 18:22
src/img/fingerprint-icon.svg Outdated Show resolved Hide resolved
src/scss/components/_inputs.scss Outdated Show resolved Hide resolved
src/scss/components/_inputs.scss Outdated Show resolved Hide resolved
src/scss/components/_inputs.scss Outdated Show resolved Hide resolved
docs/_components/form-fields.md Outdated Show resolved Hide resolved
@jmdembe jmdembe force-pushed the jd-LG-5755-checkbox-tile branch from 8139718 to 3b9a209 Compare February 16, 2022 15:05
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍 Could you also include a note in the CHANGELOG.md file?

docs/_components/form-fields.md Outdated Show resolved Hide resolved
docs/_components/form-fields.md Outdated Show resolved Hide resolved
docs/_components/form-fields.md Outdated Show resolved Hide resolved
src/img/fingerprint-icon.svg Outdated Show resolved Hide resolved
src/scss/components/_inputs.scss Show resolved Hide resolved
src/scss/components/_inputs.scss Show resolved Hide resolved
@jmdembe jmdembe force-pushed the jd-LG-5755-checkbox-tile branch from 114141f to 9282aff Compare February 16, 2022 17:49
@jmdembe jmdembe force-pushed the jd-LG-5755-checkbox-tile branch 4 times, most recently from a640755 to 8e819f4 Compare February 16, 2022 18:12
@jmdembe jmdembe force-pushed the jd-LG-5755-checkbox-tile branch from 8e819f4 to 33ecc3a Compare February 16, 2022 18:13
docs/_components/form-fields.md Outdated Show resolved Hide resolved
docs/_components/form-fields.md Outdated Show resolved Hide resolved
docs/_components/form-fields.md Outdated Show resolved Hide resolved
@jmdembe jmdembe merged commit 306925c into main Feb 16, 2022
@jmdembe jmdembe deleted the jd-LG-5755-checkbox-tile branch February 16, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants