Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove width non-responsive override #248

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Remove width non-responsive override #248

merged 1 commit into from
Sep 13, 2021

Conversation

aduth
Copy link
Member

@aduth aduth commented Sep 10, 2021

Why: These were kept in #236 as they differed from USWDS defaults, but they were identical to the default as of the original file creation. USWDS later changed the default, and since we had no explicit reason to disable responsive styles, we should inherit the default instead.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

**Why**: These were kept in #236 as they differed from USWDS defaults, but they _were_ identical to the default as of the original file creation. USWDS later [changed the default](uswds/uswds@16806bd), and since we had no explicit reason to disable responsive styles, we should inherit the default instead.
@aduth aduth force-pushed the aduth-width-responsive branch from 19e9892 to 21b290f Compare September 13, 2021 16:50
@aduth aduth merged commit 29d3b33 into main Sep 13, 2021
@aduth aduth deleted the aduth-width-responsive branch September 13, 2021 19:30
@aduth aduth mentioned this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants