Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14389: Add analytics for consent screen email selection #11321

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Oct 7, 2024

🎫 Ticket

LG-14389

🛠 Summary of changes

Logs analytics events when the user visits and submits the email selection screen when prompted to consent to share information with a partner.

This leverages existing analytics events created for changing the selected email for a partner in LG-13665 (#11196), using the property needs_completion_screen_reason to differentiate if the email was changed stemming from the consent screen.

📜 Testing Plan

Prerequisites:

  • If you've already consented for the OIDC sample application, sign in and revoke consent from the "Connected accounts" page of your account dashboard
  • You must have multiple email addresses associated with your account

Validate that the expected events are logged:

  1. Run make watch_events in a separate terminal process
  2. Run sample application in a separate terminal process
  3. Go to http://localhost:9292
  4. Click "Sign in"
  5. Sign in
  6. When prompted to consent to share information, click "Edit email address"
  7. Observe in make watch_events terminal process the event sp_select_email_visited with a needs_completion_screen_reason value
  8. Submit the page with your preferred email to share
  9. Observe in make watch_events terminal process the event sp_select_email_submitted with success: true and a needs_completion_screen_reason value

aduth added 2 commits October 7, 2024 13:47
changelog: Upcoming Features, Partner Email Selection, Add analytics for consent screen email selection
@aduth aduth requested a review from a team October 7, 2024 17:55
@aduth aduth merged commit 9fc64a2 into main Oct 7, 2024
2 checks passed
@aduth aduth deleted the aduth-lg-14389-selected-email-analytics branch October 7, 2024 19:15
colter-nattrass pushed a commit that referenced this pull request Oct 23, 2024
* LG-14389: Add analytics for consent screen email selection

changelog: Upcoming Features, Partner Email Selection, Add analytics for consent screen email selection

* Include needs_completion_screen_reason for submission event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants