Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Parameterize hard-coded class names #5

Open
jmcarp opened this issue Nov 29, 2015 · 4 comments
Open

Parameterize hard-coded class names #5

jmcarp opened this issue Nov 29, 2015 · 4 comments
Assignees

Comments

@jmcarp
Copy link
Contributor

jmcarp commented Nov 29, 2015

We've moved many hard-coded class names into configurable selectors, but we still have some hard-coded names. Even better would be removing these if we don't need them. A few examples:

  • term--highlight
  • accordion--collapsed
  • accordion__button

cc @noahmanger

@noahmanger
Copy link
Contributor

👍 I can look at this.

@noahmanger noahmanger self-assigned this Nov 30, 2015
@shawnbot
Copy link

shawnbot commented Dec 4, 2015

Here's a crazy idea: can we nix the class names altogether and use aria attributes instead? For instance:

@noahmanger
Copy link
Contributor

So I think I mostly addressed this here: #6

We don't need .accordion--collapsed or .accordion--button, but .term--highlight is useful because it's a presentation class that's applied to the term in the body when it's clicked in order to highlight it.

@noahmanger
Copy link
Contributor

Only thing I don't know is if we want to accept a hash of class names that people could supply in order to style aspects of the glossary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants