From 399fa3243dc78526a405fd102c00c4f7222ceddf Mon Sep 17 00:00:00 2001 From: Esurio/1673beta <60435625+1673beta@users.noreply.github.com> Date: Sun, 8 Sep 2024 23:11:21 +0900 Subject: [PATCH] =?UTF-8?q?fix:=20=E3=82=A2=E3=83=B3=E3=83=86=E3=83=8A?= =?UTF-8?q?=E3=81=A7=E6=AD=A3=E3=81=97=E3=81=8Findexable=E3=81=8Cfalse?= =?UTF-8?q?=E3=81=AA=E3=83=A6=E3=83=BC=E3=82=B6=E3=83=BC=E3=82=92=E6=A4=9C?= =?UTF-8?q?=E7=B4=A2=E3=81=8B=E3=82=89=E9=99=A4=E5=A4=96=E3=81=A7=E3=81=8D?= =?UTF-8?q?=E3=82=8B=E3=82=88=E3=81=86=E3=81=AB=20(#168)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Esurio --- CHANGELOG_engawa.md | 2 ++ packages/backend/src/server/api/endpoints/antennas/notes.ts | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG_engawa.md b/CHANGELOG_engawa.md index 72ce57c53c..3c39d60863 100644 --- a/CHANGELOG_engawa.md +++ b/CHANGELOG_engawa.md @@ -27,6 +27,8 @@ ### Server - fix: `ApPersonService`で`isIndexable`を考慮してなかった箇所がある問題 +- fix: `toot:indexable`がfalseなユーザーを検索できてしまっていた問題 +- fix: `toot:indexable`がfalseなユーザーがアンテナに載っていた問題 ### Misc diff --git a/packages/backend/src/server/api/endpoints/antennas/notes.ts b/packages/backend/src/server/api/endpoints/antennas/notes.ts index 87127d80b4..42fa97e196 100644 --- a/packages/backend/src/server/api/endpoints/antennas/notes.ts +++ b/packages/backend/src/server/api/endpoints/antennas/notes.ts @@ -107,12 +107,11 @@ export default class extends Endpoint { // eslint- const query = this.notesRepository.createQueryBuilder('note') .where('note.id IN (:...noteIds)', { noteIds: noteIds }) - .innerJoinAndSelect('note.user', 'user') + .innerJoinAndSelect('note.user', 'user', 'user.isIndexable = true') .leftJoinAndSelect('note.reply', 'reply') .leftJoinAndSelect('note.renote', 'renote') .leftJoinAndSelect('reply.user', 'replyUser') - .leftJoinAndSelect('renote.user', 'renoteUser') - .andWhere('user.isIndexable = true'); + .leftJoinAndSelect('renote.user', 'renoteUser'); this.queryService.generateVisibilityQuery(query, me); this.queryService.generateMutedUserQuery(query, me);