Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop changes: skip cropping; allow non-square crops #128

Closed
1 task done
dkotter opened this issue May 13, 2022 · 0 comments · Fixed by #130
Closed
1 task done

Crop changes: skip cropping; allow non-square crops #128

dkotter opened this issue May 13, 2022 · 0 comments · Fixed by #130
Assignees
Labels
type:enhancement New feature or request.
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented May 13, 2022

Is your enhancement related to a problem? Please describe.

In #65 it was requested that we add the ability to choose how an image is cropped (implemented in #83). But there are times when someone uploads an image that is the exact size they need and they should be able to bypass the cropping. Right now, the only option you have is to choose a crop.

I think ideal here would be to have a a Skip cropping button, similarly to how the site icon is handled.

Screen Shot 2022-05-13 at 9 45 08 AM

In addition, it seems we force the image to always be a square (which was requested here). Is there a reason why we need to force this image to always be a square? Again, using the idea of the site icon, it gives you a pre-defined crop area but than you can change that crop to be whatever size you want. I guess I'd argue we should allow that flexibility instead of forcing a square crop.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added the type:enhancement New feature or request. label May 13, 2022
@vikrampm1 vikrampm1 moved this to Incoming in Open Source Practice May 13, 2022
@jeffpaul jeffpaul added this to the 2.5.0 milestone May 13, 2022
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice May 13, 2022
@faisal-alvi faisal-alvi self-assigned this May 18, 2022
@faisal-alvi faisal-alvi moved this from To Do to In Progress in Open Source Practice May 18, 2022
@faisal-alvi faisal-alvi moved this from In Progress to In Review in Open Source Practice May 18, 2022
Repository owner moved this from In Review to Merged in Open Source Practice May 19, 2022
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants