Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure alt text is output when the avatar image is output #126

Closed
1 task done
dkotter opened this issue May 10, 2022 · 0 comments · Fixed by #127
Closed
1 task done

Ensure alt text is output when the avatar image is output #126

dkotter opened this issue May 10, 2022 · 0 comments · Fixed by #127
Assignees
Labels
type:bug Something isn’t working.
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented May 10, 2022

Describe the bug

If an author has a local avatar set and the image used for that avatar has custom alt text set, it doesn't appear that we ever use that alt text (see this report). WordPress already supports outputting the alt text on the avatar image tag if that exists, so we just need to ensure that if someone has a local avatar set, let's grab the alt text for that image and return that in the image arguments.

Steps to Reproduce

  1. Upload a new image and add alt text to it
  2. Assign that image as a local avatar to a user
  3. Create a post with that same user
  4. View the post on the front-end and see the avatar being output but no alt text

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added the type:bug Something isn’t working. label May 10, 2022
@dkotter dkotter self-assigned this May 10, 2022
@jeffpaul jeffpaul added this to the 2.5.0 milestone May 10, 2022
@jeffpaul jeffpaul moved this from Incoming to In Review in Open Source Practice May 10, 2022
@jeffpaul jeffpaul moved this to Incoming in Open Source Practice May 10, 2022
Repository owner moved this from In Review to Merged in Open Source Practice May 17, 2022
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn’t working.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants